Pepper: Expose visible_rect to PPB_VideoDecoder.GetPicture.

ppapi/cpp/video_decoder.h

Index: ppapi/cpp/video_decoder.h
diff --git a/ppapi/cpp/video_decoder.h b/ppapi/cpp/video_decoder.h
index cc7267ba680d9f1931de08118318c8049e48bd60..bfab3c5745f09d057b713050c79148e95a7858da 100644
--- a/ppapi/cpp/video_decoder.h
+++ b/ppapi/cpp/video_decoder.h
@@ -15,7 +15,7 @@
 /// @file
 /// This file defines the API to create and use a VideoDecoder resource.
 
-struct PP_FileInfo;
+struct PP_Rect;
 
 namespace pp {
 
@@ -119,6 +119,9 @@ class VideoDecoder : public Resource {
   /// When the plugin is finished using the picture, it should return it to the
   /// system by calling RecyclePicture().
   ///
+  /// @param[in] visible_rect A <code>PP_Rect</code> to hold the visible
+  /// subrectangle of the picture. The plugin should only display the visible
+  /// area of the picture.
   /// @param[in] callback A <code>CompletionCallbackWithOutput</code> to be
   /// called on completion, and on success, to hold the picture descriptor.
   ///
@@ -129,6 +132,7 @@ class VideoDecoder : public Resource {
   /// Returns PP_ERROR_ABORTED when Reset() is called, or if a call to Flush()
   /// completes while GetPicture() is pending.
   int32_t GetPicture(
+      PP_Rect* visible_rect,
       const CompletionCallbackWithOutput<PP_VideoPicture>& callback);

[dmichael (off chromium), 2014/11/05 19:28:08]

It seems pretty confusing that we have a callback with output, but *also* an
out-param. What do you think of making a small struct here or using std::pair?

[bbudge, 2014/11/05 22:41:48]

Using a new struct instead.

 
   /// Recycles a picture that the plugin has received from the decoder.