Pepper: Expose visible_rect to PPB_VideoDecoder.GetPicture.

ppapi/cpp/video_decoder.h

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PPAPI_CPP_VIDEO_DECODER_H_
 #define PPAPI_CPP_VIDEO_DECODER_H_
 
 #include "ppapi/c/pp_codecs.h"
 #include "ppapi/c/pp_size.h"
 #include "ppapi/cpp/completion_callback.h"
 #include "ppapi/cpp/graphics_3d.h"
 #include "ppapi/cpp/resource.h"
 #include "ppapi/cpp/size.h"
 
 /// @file
 /// This file defines the API to create and use a VideoDecoder resource.
 
-struct PP_FileInfo;
+struct PP_Rect;
 
 namespace pp {
 
 class InstanceHandle;
 
 /// Video decoder interface.
 ///
 /// Typical usage:
 /// - Call Create() to create a new video decoder resource.
 /// - Call Initialize() to initialize it with a 3d graphics context and the
@@ skipping 83 matching lines @@
                  uint32_t size,
                  const void* buffer,
                  const CompletionCallback& callback);
 
   /// Gets the next picture from the decoder. The picture is valid after the
   /// decoder signals completion by returning PP_OK or running |callback|. The
   /// plugin can call GetPicture() again after the decoder signals completion.
   /// When the plugin is finished using the picture, it should return it to the
   /// system by calling RecyclePicture().
   ///
+  /// @param[in] visible_rect A <code>PP_Rect</code> to hold the visible
+  /// subrectangle of the picture. The plugin should only display the visible
+  /// area of the picture.
   /// @param[in] callback A <code>CompletionCallbackWithOutput</code> to be
   /// called on completion, and on success, to hold the picture descriptor.
   ///
   /// @return An int32_t containing an error code from <code>pp_errors.h</code>.
   /// Returns PP_ERROR_FAILED if the decoder isn't initialized or if a Reset()
   /// call is pending.
   /// Returns PP_ERROR_INPROGRESS if there is another GetPicture() call pending.
   /// Returns PP_ERROR_ABORTED when Reset() is called, or if a call to Flush()
   /// completes while GetPicture() is pending.
   int32_t GetPicture(
+      PP_Rect* visible_rect,
       const CompletionCallbackWithOutput<PP_VideoPicture>& callback);

[dmichael (off chromium), 2014/11/05 19:28:08]

It seems pretty confusing that we have a callback with output, but *also* an
out-param. What do you think of making a small struct here or using std::pair?

[bbudge, 2014/11/05 22:41:48]

Using a new struct instead.

 
   /// Recycles a picture that the plugin has received from the decoder.
   /// The plugin should call this as soon as it has finished using the texture
   /// so the decoder can decode more pictures.
   ///
   /// @param[in] picture A <code>PP_VideoPicture</code> to return to the
   /// decoder.
   void RecyclePicture(const PP_VideoPicture& picture);
 
   /// Flushes the decoder. The plugin should call Flush() when it reaches the
@@ skipping 26 matching lines @@
   /// completion.
   ///
   /// @return An int32_t containing an error code from <code>pp_errors.h</code>.
     /// Returns PP_ERROR_FAILED if the decoder isn't initialized.
 int32_t Reset(const CompletionCallback& callback);
 };
 
 }  // namespace pp
 
 #endif  // PPAPI_CPP_VIDEO_DECODER_H_