Issue 703473004: [turbofan] Add AllocateHeapNumberStub to avoid runtime call.

Issue 703473004: [turbofan] Add AllocateHeapNumberStub to avoid runtime call. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer

Modified:
6 years, 1 month ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Add AllocateHeapNumberStub to avoid runtime call. TEST=unittests R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25107

Patch Set 1 #

Total comments: 2

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+178 lines, -29 lines)			Patch
M	src/arm/interface-descriptors-arm.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/arm64/interface-descriptors-arm64.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/code-factory.h	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/code-factory.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/code-stubs.h	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	src/code-stubs.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/code-stubs-hydrogen.cc	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	src/compiler/change-lowering.cc	View	2 chunks	+9 lines, -11 lines	2 comments	Download
M	src/ia32/interface-descriptors-ia32.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/interface-descriptors.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	src/x64/interface-descriptors-x64.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	test/unittests/compiler/change-lowering-unittest.cc	View	1 chunk	+3 lines, -7 lines	0 comments	Download
M	test/unittests/compiler/node-test-utils.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	test/unittests/compiler/node-test-utils.cc	View	2 chunks	+71 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with one comment). https://codereview.chromium.org/703473004/diff/1/src/compiler/change-lowering.cc File src/compiler/change-lowering.cc (right): https://codereview.chromium.org/703473004/diff/1/src/compiler/change-lowering.cc#newcode74 src/compiler/change-lowering.cc:74: callable.descriptor(), 0, CallDescriptor::kPatchableCallSite); Does this ...

6 years, 1 month ago (2014-11-04 12:56:05 UTC) #3

Benedikt Meurer

https://codereview.chromium.org/703473004/diff/1/src/compiler/change-lowering.cc File src/compiler/change-lowering.cc (right): https://codereview.chromium.org/703473004/diff/1/src/compiler/change-lowering.cc#newcode74 src/compiler/change-lowering.cc:74: callable.descriptor(), 0, CallDescriptor::kPatchableCallSite); On 2014/11/04 12:56:05, Michael Starzinger wrote: ...

6 years, 1 month ago (2014-11-04 12:57:50 UTC) #4

Benedikt Meurer

6 years, 1 month ago (2014-11-04 12:58:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 25107 (presubmit successful).

Expand Messages | Collapse Messages