Re-land: content: Cleanup GpuMemoryBuffers when child process is removed.

Re-land: content: Cleanup GpuMemoryBuffers when child process is removed.

This keeps track of buffers allocated for child processes in
BrowserGpuMemoryBufferManager and makes sure
GpuMemoryBufferImpl::DeletedByChildProcess is called
appropriately when a process is removed.

BUG=

Committed: https://crrev.com/dca0e8fc4e127398a1da5dbbfa12c3425b65958f
Cr-Commit-Position: refs/heads/master@{#303136}

[reveman, 2014-11-05 02:17:40]

reveman@chromium.org changed reviewers:
+ alexst@chromium.org, piman@chromium.org

[piman, 2014-11-05 06:08:03]

LGTM. It's safer too not to rely on the renderer's provided type.

[reveman, 2014-11-05 07:08:37]

reveman@chromium.org changed reviewers:
+ kenrb@chromium.org

[reveman, 2014-11-05 07:08:38]

+kenrb for content/common/child_process_messages.h

[alexst (slow to review), 2014-11-05 13:51:23]

lgtm

https://codereview.chromium.org/703463005/diff/40001/content/browser/gpu/brow...
File content/browser/gpu/browser_gpu_memory_buffer_manager.cc (right):

https://codereview.chromium.org/703463005/diff/40001/content/browser/gpu/brow...
content/browser/gpu/browser_gpu_memory_buffer_manager.cc:146: // This can happen
if a child process manage to trigger a call to this while
nit: ..if a child process managed (or manages).

[reveman, 2014-11-05 16:22:51]

https://codereview.chromium.org/703463005/diff/40001/content/browser/gpu/brow...
File content/browser/gpu/browser_gpu_memory_buffer_manager.cc (right):

https://codereview.chromium.org/703463005/diff/40001/content/browser/gpu/brow...
content/browser/gpu/browser_gpu_memory_buffer_manager.cc:146: // This can happen
if a child process manage to trigger a call to this while
On 2014/11/05 13:51:23, alexst wrote:
> nit: ..if a child process managed (or manages).

Done.

[kenrb, 2014-11-05 22:52:57]

ipc lgtm

[reveman, 2014-11-05 23:03:32]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-11-05 23:05:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/703463005/60001

[commit-bot: I haz the power, 2014-11-06 00:23:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-06 00:23:28]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[reveman, 2014-11-06 00:39:44]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-11-06 00:40:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/703463005/60001

[commit-bot: I haz the power, 2014-11-06 01:39:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-06 01:39:43]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[reveman, 2014-11-06 04:44:09]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-11-06 04:45:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/703463005/80001

[commit-bot: I haz the power, 2014-11-06 05:48:37]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-11-06 05:49:06]

Patchset 5 (id:??) landed as
https://crrev.com/32e22ea8b72f52ac89e5d5720d1a26596f015caf
Cr-Commit-Position: refs/heads/master@{#302968}

[yhirano, 2014-11-06 08:24:01]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/709433002/ by yhirano@chromium.org.

The reason for reverting is: Blink layout tests are failing and this CL might be
the cause. Let me revert this CL..

[yhirano, 2014-11-06 10:47:33]

On 2014/11/06 08:24:01, yhirano wrote:
> A revert of this CL (patchset #5 id:80001) has been created in
> https://codereview.chromium.org/709433002/ by mailto:yhirano@chromium.org.
> 
> The reason for reverting is: Blink layout tests are failing and this CL might
be
> the cause. Let me revert this CL..

The revert restored the tests.
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6/builds/...
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6/builds/...

[reveman, 2014-11-06 23:37:05]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-11-06 23:38:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/703463005/100001

[commit-bot: I haz the power, 2014-11-07 00:46:21]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-11-07 00:47:07]

Patchset 6 (id:??) landed as
https://crrev.com/dca0e8fc4e127398a1da5dbbfa12c3425b65958f
Cr-Commit-Position: refs/heads/master@{#303136}