Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: content/child/child_gpu_memory_buffer_manager.cc

Issue 703463005: Re-land: content: Cleanup GpuMemoryBuffers when child process is removed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gpu-memory-buffer-id-refactor
Patch Set: add manager null check to ~RenderMessageFilter Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/child/child_gpu_memory_buffer_manager.h" 5 #include "content/child/child_gpu_memory_buffer_manager.h"
6 6
7 #include "content/child/child_thread.h" 7 #include "content/child/child_thread.h"
8 #include "content/common/child_process_messages.h" 8 #include "content/common/child_process_messages.h"
9 #include "content/common/gpu/client/gpu_memory_buffer_impl.h" 9 #include "content/common/gpu/client/gpu_memory_buffer_impl.h"
10 10
11 namespace content { 11 namespace content {
12 namespace { 12 namespace {
13 13
14 void DeletedGpuMemoryBuffer(ThreadSafeSender* sender, 14 void DeletedGpuMemoryBuffer(ThreadSafeSender* sender,
15 gfx::GpuMemoryBufferType type,
16 gfx::GpuMemoryBufferId id, 15 gfx::GpuMemoryBufferId id,
17 uint32 sync_point) { 16 uint32 sync_point) {
18 TRACE_EVENT0("renderer", 17 TRACE_EVENT0("renderer",
19 "ChildGpuMemoryBufferManager::DeletedGpuMemoryBuffer"); 18 "ChildGpuMemoryBufferManager::DeletedGpuMemoryBuffer");
20 sender->Send( 19 sender->Send(new ChildProcessHostMsg_DeletedGpuMemoryBuffer(id, sync_point));
21 new ChildProcessHostMsg_DeletedGpuMemoryBuffer(type, id, sync_point));
22 } 20 }
23 21
24 } // namespace 22 } // namespace
25 23
26 ChildGpuMemoryBufferManager::ChildGpuMemoryBufferManager( 24 ChildGpuMemoryBufferManager::ChildGpuMemoryBufferManager(
27 ThreadSafeSender* sender) 25 ThreadSafeSender* sender)
28 : sender_(sender) { 26 : sender_(sender) {
29 } 27 }
30 28
31 ChildGpuMemoryBufferManager::~ChildGpuMemoryBufferManager() { 29 ChildGpuMemoryBufferManager::~ChildGpuMemoryBufferManager() {
(...skipping 15 matching lines...) Expand all
47 IPC::Message* message = new ChildProcessHostMsg_SyncAllocateGpuMemoryBuffer( 45 IPC::Message* message = new ChildProcessHostMsg_SyncAllocateGpuMemoryBuffer(
48 size.width(), size.height(), format, usage, &handle); 46 size.width(), size.height(), format, usage, &handle);
49 bool success = sender_->Send(message); 47 bool success = sender_->Send(message);
50 if (!success) 48 if (!success)
51 return scoped_ptr<gfx::GpuMemoryBuffer>(); 49 return scoped_ptr<gfx::GpuMemoryBuffer>();
52 50
53 scoped_ptr<GpuMemoryBufferImpl> buffer(GpuMemoryBufferImpl::CreateFromHandle( 51 scoped_ptr<GpuMemoryBufferImpl> buffer(GpuMemoryBufferImpl::CreateFromHandle(
54 handle, 52 handle,
55 size, 53 size,
56 format, 54 format,
57 base::Bind(&DeletedGpuMemoryBuffer, sender_, handle.type, handle.id))); 55 base::Bind(&DeletedGpuMemoryBuffer, sender_, handle.id)));
58 if (!buffer) { 56 if (!buffer) {
59 sender_->Send(new ChildProcessHostMsg_DeletedGpuMemoryBuffer( 57 sender_->Send(new ChildProcessHostMsg_DeletedGpuMemoryBuffer(handle.id, 0));
60 handle.type, handle.id, 0));
61 return scoped_ptr<gfx::GpuMemoryBuffer>(); 58 return scoped_ptr<gfx::GpuMemoryBuffer>();
62 } 59 }
63 60
64 return buffer.Pass(); 61 return buffer.Pass();
65 } 62 }
66 63
67 gfx::GpuMemoryBuffer* 64 gfx::GpuMemoryBuffer*
68 ChildGpuMemoryBufferManager::GpuMemoryBufferFromClientBuffer( 65 ChildGpuMemoryBufferManager::GpuMemoryBufferFromClientBuffer(
69 ClientBuffer buffer) { 66 ClientBuffer buffer) {
70 return GpuMemoryBufferImpl::FromClientBuffer(buffer); 67 return GpuMemoryBufferImpl::FromClientBuffer(buffer);
71 } 68 }
72 69
73 void ChildGpuMemoryBufferManager::SetDestructionSyncPoint( 70 void ChildGpuMemoryBufferManager::SetDestructionSyncPoint(
74 gfx::GpuMemoryBuffer* buffer, 71 gfx::GpuMemoryBuffer* buffer,
75 uint32 sync_point) { 72 uint32 sync_point) {
76 static_cast<GpuMemoryBufferImpl*>(buffer) 73 static_cast<GpuMemoryBufferImpl*>(buffer)
77 ->set_destruction_sync_point(sync_point); 74 ->set_destruction_sync_point(sync_point);
78 } 75 }
79 76
80 } // namespace content 77 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/renderer_host/render_message_filter.cc ('k') | content/common/child_process_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698