Move more extension action cocoa logic into the platform delegate

Move more extension action cocoa logic into the platform delegate.

Move the logic for extension action context menus and
close-popup activate-action observations into the cocoa
platform delegate.

BUG=429810
Committed: https://crrev.com/0313803a216893aff1586a2e92c8a2ab46bee8be
Cr-Commit-Position: refs/heads/master@{#302723}

[Devlin, 2014-11-03 21:05:30]

Patchset #1 (id:1) has been deleted

[Devlin, 2014-11-03 21:05:35]

Patchset #1 (id:20001) has been deleted

[Devlin, 2014-11-03 21:31:17]

Patchset #1 (id:40001) has been deleted

[Devlin, 2014-11-03 21:58:25]

rdevlin.cronin@chromium.org changed reviewers:
+ avi@chromium.org

[Devlin, 2014-11-03 21:58:26]

Avi, please take a look.

cc: Finnur and Scott (feel free to move yourselves to reviewers, if you like)

[Avi (use Gerrit), 2014-11-03 22:04:00]

The cocoa stuff LGTM. Can you have an extensions peep double-check it?

https://codereview.chromium.org/703443002/diff/60001/chrome/browser/ui/cocoa/...
File
chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm
(right):

https://codereview.chromium.org/703443002/diff/60001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm:138:
case extensions::NOTIFICATION_EXTENSION_COMMAND_PAGE_ACTION_MAC: {
Not for this CL, but why don't we collapse these?

[Devlin, 2014-11-03 22:07:27]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org

[Devlin, 2014-11-03 22:07:28]

On 2014/11/03 22:04:00, Avi wrote:
> The cocoa stuff LGTM. Can you have an extensions peep double-check it?

Sure thing.  Finnur, guess you're not off the hook after all! ;)

[finnur@ moved to reviewers]

https://codereview.chromium.org/703443002/diff/60001/chrome/browser/ui/cocoa/...
File
chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm
(right):

https://codereview.chromium.org/703443002/diff/60001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm:138:
case extensions::NOTIFICATION_EXTENSION_COMMAND_PAGE_ACTION_MAC: {
On 2014/11/03 22:04:00, Avi wrote:
> Not for this CL, but why don't we collapse these?

I can't think of a reason to not (since extensions can only have one or the
other).  I'll add it to my todo list. :)  (Similarly, it seems odd to send out a
notification for a popup to close - I wanna investigate that one, too.)

[Finnur, 2014-11-04 22:14:08]

I approve of this message.

LGTM.

(Sorry for the lateness, the new Inbox had this fall through the cracks).

[Devlin, 2014-11-04 23:54:09]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-11-04 23:55:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/703443002/60001

[commit-bot: I haz the power, 2014-11-05 00:40:47]

Committed patchset #1 (id:60001)

[commit-bot: I haz the power, 2014-11-05 00:42:26]

Patchset 1 (id:??) landed as
https://crrev.com/0313803a216893aff1586a2e92c8a2ab46bee8be
Cr-Commit-Position: refs/heads/master@{#302723}