chrome/browser/ui/cocoa/toolbar/toolbar_action_view_delegate_cocoa.h - Issue 703443002: Move more extension action cocoa logic into the platform delegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/toolbar/toolbar_action_view_delegate_cocoa.h

Issue 703443002: Move more extension action cocoa logic into the platform delegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_toolbar_abstract_extension_action

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm ('K') | « chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/toolbar/toolbar_action_view_delegate_cocoa.h

diff --git a/chrome/browser/ui/cocoa/toolbar/toolbar_action_view_delegate_cocoa.h b/chrome/browser/ui/cocoa/toolbar/toolbar_action_view_delegate_cocoa.h

index 39424b63e5aaad85cb3fddd1c029dcb6b2f5d804..a281cf4b9b6eca9b5dc2e5694435a34482f3b32e 100644

--- a/chrome/browser/ui/cocoa/toolbar/toolbar_action_view_delegate_cocoa.h

+++ b/chrome/browser/ui/cocoa/toolbar/toolbar_action_view_delegate_cocoa.h

@@ -7,11 +7,18 @@

#include "chrome/browser/ui/toolbar/toolbar_action_view_delegate.h"

+@class ExtensionActionContextMenuController;

class ToolbarActionViewDelegateCocoa : public ToolbarActionViewDelegate {

public:

// A cocoa-specific implementation to return the point used when showing a

// popup.

virtual NSPoint GetPopupPoint() = 0;

+ // TODO(devlin): Ideally, this would take a

+ // ToolbarActionContextMenuController, but that doesn't exist (yet).

+ virtual void SetContextMenuController(

+ ExtensionActionContextMenuController* menuController) = 0;

};

#endif // CHROME_BROWSER_UI_COCOA_TOOLBAR_TOOLBAR_ACTION_VIEW_DELEGATE_COCOA_H_