Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: tools/telemetry/telemetry/core/platform/linux_platform_backend.py

Issue 703203004: [telemetry] When launching an application elevated, check if it has NOPASSWD in sudoers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use sudo -l. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/platform/linux_platform_backend.py
diff --git a/tools/telemetry/telemetry/core/platform/linux_platform_backend.py b/tools/telemetry/telemetry/core/platform/linux_platform_backend.py
index 54fde65707b7e81da791bab67dc4d8b1a485da6b..d29fd4e2efc282b8bd95a78356403d489076a029 100644
--- a/tools/telemetry/telemetry/core/platform/linux_platform_backend.py
+++ b/tools/telemetry/telemetry/core/platform/linux_platform_backend.py
@@ -145,9 +145,10 @@ class LinuxPlatformBackend(
if changed or not self.CanLaunchApplication('ipfw'):
if not self._IsIpfwKernelModuleInstalled():
- subprocess.check_call(['sudo', 'insmod', ipfw_mod])
+ subprocess.check_call(['/usr/bin/sudo', 'insmod', ipfw_mod])
os.chmod(ipfw_bin, 0755)
- subprocess.check_call(['sudo', 'cp', ipfw_bin, '/usr/local/sbin'])
+ subprocess.check_call(
+ ['/usr/bin/sudo', 'cp', ipfw_bin, '/usr/local/sbin'])
assert self.CanLaunchApplication('ipfw'), 'Failed to install ipfw. ' \
'ipfw provided binaries are not supported for linux kernel < 3.13. ' \

Powered by Google App Engine
This is Rietveld 408576698