Run NaClEnvCleanser in standalone sel_ldr (in addition to sel_main_chrome). Add a couple of ld.so...

Allow all NACLENV_* vars through (but losing the prefix). Even in sel_ldr.

This change will let us run Valgrind on unmodified nexes by LD_PRELOAD-ing
libvalgrind.so in runtime. This is how Valgrind works with native binaries.
Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=5415

[eugenis, 2011-05-17 12:20:09]

Please see if this is acceptable. I'll extend env_cleanser_test then.

sel_main_chrome already passes the filtered environment to the nexe, so it's
probably a good idea to do it in sel_ldr as well.

We use NACL_ prefix on environment variables for the untrusted dynamic linker.

[eugenis, 2011-05-17 13:32:49]

Mark suggested passing through all environment variables starting with some
prefix (NACL_ or NACLENV_ or something), stripping this prefix in the process.
This can be done instead of extending the whitelist with NACL_LD_* vars.

WDYT?

[pasko-google - do not use, 2011-05-17 13:45:50]

On 2011/05/17 13:32:49, eugenis wrote:
> Mark suggested passing through all environment variables starting with some
> prefix (NACL_ or NACLENV_ or something), stripping this prefix in the process.
> This can be done instead of extending the whitelist with NACL_LD_* vars.
> 
> WDYT?

sounds fine

[eugenis, 2011-05-17 14:33:01]

PTAL

[eugenis, 2011-05-18 14:30:42]

ping

[bsy, 2011-05-18 18:25:07]

seems reasonable; just a q regarding adding env_cleanser to the ldr_inputs -- i
think this should be a library dependency, not duplicating the .o file into the
library.

http://codereview.chromium.org/7031023/diff/5003/src/trusted/service_runtime/...
File src/trusted/service_runtime/build.scons (right):

http://codereview.chromium.org/7031023/diff/5003/src/trusted/service_runtime/...
src/trusted/service_runtime/build.scons:214: ldr_inputs += ['env_cleanser']
doesn't this put a copy of env_cleanser.o in both libsel and libenv_cleanser? 
why?

[Evgeniy Stepanov, 2011-05-18 19:05:05]

http://codereview.chromium.org/7031023/diff/5003/src/trusted/service_runtime/...
File src/trusted/service_runtime/build.scons (right):

http://codereview.chromium.org/7031023/diff/5003/src/trusted/service_runtime/...
src/trusted/service_runtime/build.scons:214: ldr_inputs += ['env_cleanser']
On 2011/05/18 18:25:07, bsy wrote:
> doesn't this put a copy of env_cleanser.o in both libsel and libenv_cleanser? 
> why?

Did not want to include libenv_cleanser in every target than depends on libsel,
there are, like, 7 of them. Or does scons somehow keep dependencies between
static libraries?

I'm fine with doing this either way.

[bsy, 2011-05-18 19:32:28]

bradn:

about... a year or more ago... you mentioned that you had some ideas on how
to establish a convention whereby each library export a list of libraries
that it in turn depend on, and for each library to compute its dependency
transitive closure to put into its export list.  could you remind me?  i
think maybe it's time for us to do a cleanup and implement this....

-bsy

On Wed, May 18, 2011 at 12:05 PM, <eugenis@google.com> wrote:

>
>
>
http://codereview.chromium.org/7031023/diff/5003/src/trusted/service_runtime/...
> File src/trusted/service_runtime/build.scons (right):
>
>
>
http://codereview.chromium.org/7031023/diff/5003/src/trusted/service_runtime/...
> src/trusted/service_runtime/build.scons:214: ldr_inputs +=
> ['env_cleanser']
> On 2011/05/18 18:25:07, bsy wrote:
>
>> doesn't this put a copy of env_cleanser.o in both libsel and
>>
> libenv_cleanser?
>
>> why?
>>
>
> Did not want to include libenv_cleanser in every target than depends on
> libsel, there are, like, 7 of them. Or does scons somehow keep
> dependencies between static libraries?
>
> I'm fine with doing this either way.
>
>
> http://codereview.chromium.org/7031023/
>



-- 
bennet s yee
i usually don't capitalize due to mild tendonitis

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

[eugenis, 2011-05-19 08:20:34]

I've changed libsel.a to not include env_cleanser.o, updated env_cleanser_test,
and also tweaked sel_ldr_launcher.cc a bit to pass presubmit checks.

[eugenis, 2011-05-24 09:33:29]

Is it OK to commit?

[bsy, 2011-05-24 13:01:24]

lgtm.

sorry 'bout the delay.