--trust-primitives: Remove bounds checks and receiver and argument type checks

--trust-primitives: Remove bounds checks and receiver and argument type checks

The model is that if your program is tested and never
  - has a bounds error on a primitive array
  - tries to do arithmetic on null
then when compiled with --trust-primitive it will produce the same
answer, but with smaller and faster code.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41682

[sra1, 2014-11-06 04:09:25]

sra@google.com changed reviewers:
+ floitsch@google.com

[sra1, 2014-11-06 04:09:26]

There are O(40) tests in corelib and language that fail.
I'm going through them, but all so far appear to be expected - e.g.
Expect.throws() where the error is null+42

[sra1, 2014-11-08 03:14:03]

On 2014/11/06 04:09:26, sra1 wrote:
> There are O(40) tests in corelib and language that fail.
> I'm going through them, but all so far appear to be expected - e.g.
> Expect.throws() where the error is null+42

These tests fail.  As I said, most are triggering receiver checks, argument
checks or bounds checks in some form.
I could work to split the tests that have subtests that should still pass.

python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
corelib/core_runtime_types_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
corelib/error_stack_trace_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
corelib/indexed_list_access_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
corelib/iterable_element_at_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
corelib/list_growable_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
corelib/list_removeat_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
corelib/list_test/01
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
corelib/list_test/none
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
dart2js_extra/bailout8_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
dart2js_extra/bounds_check_test/01
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
dart2js_extra/bounds_check_test/02
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
dart2js_extra/bounds_check_test/03
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
dart2js_extra/bounds_check_test/04
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
dart2js_extra/bounds_check_test/05
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
dart2js_extra/bounds_check_test/06
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
dart2js_extra/bounds_check_test/07
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
dart2js_extra/bounds_check_test/08
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
dart2js_extra/code_motion_exception_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
dart2js_extra/constant_javascript_semantics2_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
dart2js_extra/constant_javascript_semantics3_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
dart2js_extra/int_index_test/01
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
dart2js_extra/int_index_test/02
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
dart2js_extra/int_index_test/03
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
dart2js_extra/int_index_test/04
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
dart2js_extra/invalid_length_negative_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/arithmetic2_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/final_syntax_test/10
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/inference_super_constructor_call_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/inferrer_constructor2_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/inferrer_constructor4_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/inferrer_constructor5_test/01
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/inferrer_constructor_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/inferrer_this_access_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/lazy_static3_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/list_double_index_in_loop2_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/list_double_index_in_loop_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/list_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/multiple_field_assignment_constructor_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/no_such_method_empty_selector_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/operator_equals_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/optimized_constant_array_string_access_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/optimized_string_charat_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/range_analysis2_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/refine_receiver_null_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/side_effect_throw_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/string_charcode_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/super_inferrer_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/type_propagation_in_for_update_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/value_range2_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/value_range3_test
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
language/value_range_test

[sra1, 2014-11-10 23:58:50]

Ping.

Benchmark patches against r41648:

Swarm saves
  27515 --trust-type-annotations
  25303 --trust-primitives
  56472 both (7.9%)

Dart2js minified gzip saves
  1.77% --trust-type-annotations
  2.09% --trust-primitives
  3.79% both

Angular bouncy balls minified gzip saves
  4.90% --trust-type-annotations
  2.00% --trust-primitives
  6.98% both

[floitsch, 2014-11-11 10:02:04]

LGTM.
Sorry for the delay.
If it happens again, ping every day.

https://codereview.chromium.org/703083002/diff/20001/pkg/compiler/lib/src/ssa...
File pkg/compiler/lib/src/ssa/optimize.dart (right):

https://codereview.chromium.org/703083002/diff/20001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/optimize.dart:906: if (compiler.trustPrimitives)
return;
Ok for this CL, but in the future (i.e. the CPS IR) I want to go away from using
"compiler", and make the dependencies more explicit.
For example, here, we should just pass in the flag.
If that becomes unreasonable, there should be a different class/interface that
identifies the things that are needed for the optimization.
For global flags (like "trustPrimitives") it's not a big deal, but when reading
global information (like what classes are alive) we need to get better at
tracking dependencies.

[sra1, 2014-11-12 02:27:37]

https://codereview.chromium.org/703083002/diff/20001/pkg/compiler/lib/src/ssa...
File pkg/compiler/lib/src/ssa/optimize.dart (right):

https://codereview.chromium.org/703083002/diff/20001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/optimize.dart:906: if (compiler.trustPrimitives)
return;
On 2014/11/11 10:02:04, floitsch wrote:
> Ok for this CL, but in the future (i.e. the CPS IR) I want to go away from
using
> "compiler", and make the dependencies more explicit.
> For example, here, we should just pass in the flag.
> If that becomes unreasonable, there should be a different class/interface that
> identifies the things that are needed for the optimization.
> For global flags (like "trustPrimitives") it's not a big deal, but when
reading
> global information (like what classes are alive) we need to get better at
> tracking dependencies.

I passed the bool.

[sra1, 2014-11-12 02:31:42]

Committed patchset #3 (id:40001) manually as 41682 (presubmit successful).