src/ia32/full-codegen-ia32.cc - Issue 7029030: Use page header information to test for InNewSpace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 7029030: Use page header information to test for InNewSpace. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/gc

Patch Set: Addressed review comments. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index 715362be05bad55544e17641ce0299371109eb55..07f8cbfc6b754a000084f435a346955643a5abdd 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -3185,11 +3185,8 @@ void FullCodeGenerator::EmitSwapElements(ZoneList<Expression*>* args) {

__ mov(Operand(index_1, 0), temp);

NearLabel no_remembered_set;

- __ InNewSpace(elements, temp, equal, &no_remembered_set);

- __ CheckPageFlag(elements,

- temp,

- MemoryChunk::SCAN_ON_SCAVENGE,

- not_zero,

+ __ CheckPageFlag(elements, temp,

+ MemoryChunk::SCAN_ON_SCAVENGE, not_zero,

&no_remembered_set);

__ mov(object, elements);

« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/macro-assembler-ia32.h » ('j') | no next file with comments »