Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: src/ia32/code-stubs-ia32.cc

Issue 7029030: Use page header information to test for InNewSpace. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/gc
Patch Set: Addressed review comments. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap-inl.h ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ia32/code-stubs-ia32.cc
diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc
index bf88f01cb7363243b6d6e700de357ca9dc1c22ef..7b15d75a645ba5d4f58ddd50a9a234509eba788f 100644
--- a/src/ia32/code-stubs-ia32.cc
+++ b/src/ia32/code-stubs-ia32.cc
@@ -6016,7 +6016,9 @@ void RecordWriteStub::GenerateIncremental(MacroAssembler* masm) {
Label value_in_old_space;
- __ InNewSpace(value_, regs_.scratch0(), not_equal, &value_in_old_space);
+ __ CheckPageFlag(value_, regs_.scratch0(),
+ MemoryChunk::IN_NEW_SPACE, zero,
+ &value_in_old_space);
// After this point the value_ register may have been overwritten since it is
// also one of the scratch registers.
@@ -6055,7 +6057,9 @@ void RecordWriteStub::GenerateIncrementalValueIsInNewSpace(
Label value_in_new_space_object_is_black_no_remembered_set;
// The value is in new space. Check the object.
- __ InNewSpace(regs_.object(), regs_.scratch0(), equal, &both_in_new_space);
+ __ CheckPageFlag(regs_.object(), regs_.scratch0(),
+ MemoryChunk::IN_NEW_SPACE, not_zero,
+ &both_in_new_space);
// Value is in new space, object is in old space. Could we be lucky and find
// the scan_on_scavenge flag on the object's page?
@@ -6200,10 +6204,9 @@ void RecordWriteStub::GenerateIncrementalValueIsInOldSpace(
// object is in in order to find its colour.
__ bind(&value_is_white);
__ pop(regs_.object());
- __ InNewSpace(regs_.object(),
- regs_.scratch0(),
- equal,
- &value_in_old_space_and_white_object_in_new_space);
+ __ CheckPageFlag(regs_.object(), regs_.scratch0(),
+ MemoryChunk::IN_NEW_SPACE, not_zero,
+ &value_in_old_space_and_white_object_in_new_space);
// Both in old space, value is white and can't be marked.
__ InOldSpaceIsBlack(regs_.object(),
« no previous file with comments | « src/heap-inl.h ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698