Issue 702793003: Fix duplicated strings in ADMX templates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 702793003: Fix duplicated strings in ADMX templates. (Closed)

Created:
6 years, 1 month ago by Joao da Silva

Modified:
6 years, 1 month ago

Reviewers:

CC:
grit-developer_googlegroups.com

Base URL:
http://grit-i18n.googlecode.com/svn/trunk/

Visibility:
Public.

Fix duplicated strings in ADMX templates. Also fixed the generated <string> IDs, which can't contain "." characters. BUG=chromium:429117 Committed: https://code.google.com/p/grit-i18n/source/detail?r=181

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+259 lines, -36 lines)			Patch
M	grit/format/policy_templates/writers/adm_writer.py	View	6 chunks	+15 lines, -9 lines	0 comments	Download
M	grit/format/policy_templates/writers/adm_writer_unittest.py	View	1 chunk	+98 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/adml_writer.py	View	5 chunks	+27 lines, -27 lines	0 comments	Download
M	grit/format/policy_templates/writers/adml_writer_unittest.py	View	1 chunk	+56 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/admx_writer.py	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/admx_writer_unittest.py	View	1 chunk	+61 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Joao da Silva

Original review at https://codereview.chromium.org/695613003.

6 years, 1 month ago (2014-11-05 11:10:35 UTC) #1

Joao da Silva

6 years, 1 month ago (2014-11-05 11:10:56 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r181 (presubmit successful).