Issue 695613003: Fix duplicated strings in ADMX templates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 695613003: Fix duplicated strings in ADMX templates. (Closed)

Created:
6 years, 1 month ago by Joao da Silva

Modified:
6 years ago

Reviewers:
pastarmovj

CC:
grit-developer_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/grit-i18n.git@master

Visibility:
Public.

Fix duplicated strings in ADMX templates. Also fixed the generated <string> IDs, which can't contain "." characters. BUG=chromium:429117

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+259 lines, -36 lines)			Patch
M	grit/format/policy_templates/writers/adm_writer.py	View	1	6 chunks	+15 lines, -9 lines	0 comments	Download
M	grit/format/policy_templates/writers/adm_writer_unittest.py	View	1	1 chunk	+98 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/adml_writer.py	View		5 chunks	+27 lines, -27 lines	0 comments	Download
M	grit/format/policy_templates/writers/adml_writer_unittest.py	View	1	1 chunk	+56 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/admx_writer.py	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/admx_writer_unittest.py	View	1	1 chunk	+61 lines, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

Joao da Silva

Added a couple of tests, and even found 2 issues! :-) PTAL

6 years, 1 month ago (2014-11-04 15:11:51 UTC) #4

pastarmovj

I am glad that annoying you with asking for tests was not in vein :) ...

6 years, 1 month ago (2014-11-04 16:33:07 UTC) #5

This change has been committed directly to SVN. Closing.