Issue 702783002: [Merge] Pepper: Access PepperMediaDeviceManager through a WeakPtr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 702783002: [Merge] Pepper: Access PepperMediaDeviceManager through a WeakPtr (Closed)

Created:
6 years, 1 month ago by dmichael (off chromium)

Modified:
6 years, 1 month ago

Reviewers:
teravest

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@2125

Project:
chromium

Visibility:
Public.

[Merge] Pepper: Access PepperMediaDeviceManager through a WeakPtr Its lifetime is scoped to the RenderFrame, and it might go away before the hosts that refer to it. BUG=423030 Committed: https://crrev.com/3a2cf7d1376ae33054b878232fb38b8fbed29e31 Cr-Commit-Position: refs/heads/master@{#299897} TBR=teravest@chromium.org Review URL: https://codereview.chromium.org/653243003 Cr-Commit-Position: refs/branch-heads/2171@{#245} Cr-Branched-From: 267aeeb8d85c8503a7fd12bd14654b8ea78d3974-refs/heads/master@{#297060} (cherry picked from commit 14ea095e585e23aa073c1434bd75d6a3e055836b) Committed: https://chromium.googlesource.com/chromium/src/+/db8e2abccd737b0513a2cd11add50b543783f2da

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -11 lines)			Patch
M	content/renderer/pepper/pepper_device_enumeration_host_helper.h	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/pepper_device_enumeration_host_helper.cc	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/pepper_device_enumeration_host_helper_unittest.cc	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/pepper_media_device_manager.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/renderer/pepper/pepper_media_device_manager.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/pepper_platform_audio_input.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/pepper/pepper_platform_video_capture.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

dmichael (off chromium)

Committed patchset #2 (id:20001) manually as db8e2abccd737b0513a2cd11add50b543783f2da (presubmit successful).

6 years, 1 month ago (2014-11-05 00:11:53 UTC) #1

Message was sent while issue was closed.

lgtm