Issue 653243003: Pepper: Access PepperMediaDeviceManager through a WeakPtr

Issue 653243003: Pepper: Access PepperMediaDeviceManager through a WeakPtr (Closed)

Created:
6 years, 2 months ago by dmichael (off chromium)

Modified:
6 years, 1 month ago

Reviewers:
teravest

CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Pepper: Access PepperMediaDeviceManager through a WeakPtr Its lifetime is scoped to the RenderFrame, and it might go away before the hosts that refer to it. BUG=423030 Committed: https://crrev.com/3a2cf7d1376ae33054b878232fb38b8fbed29e31 Cr-Commit-Position: refs/heads/master@{#299897} R=teravest@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/14ea095e585e23aa073c1434bd75d6a3e055836b

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -11 lines)			Patch
M	content/renderer/pepper/pepper_device_enumeration_host_helper.h	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/pepper_device_enumeration_host_helper.cc	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/pepper_device_enumeration_host_helper_unittest.cc	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/pepper_media_device_manager.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/renderer/pepper/pepper_media_device_manager.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/pepper_platform_audio_input.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/pepper/pepper_platform_video_capture.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 9 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653243003/1

6 years, 2 months ago (2014-10-16 15:34:17 UTC) #5

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/3a2cf7d1376ae33054b878232fb38b8fbed29e31 Cr-Commit-Position: refs/heads/master@{#299897}

6 years, 2 months ago (2014-10-16 15:54:31 UTC) #7

dmichael (off chromium)

6 years, 2 months ago (2014-10-23 16:20:36 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
14ea095e585e23aa073c1434bd75d6a3e055836b (presubmit successful).