Move ViewDisplayList to GraphicsLayer

Move ViewDisplayList to GraphicsLayer

This CL moves ViewDisplayList to GraphicsLayer and renames it to
DisplayItemList.

DisplayItemList and the DisplayItems are also moved to platform/graphics
to resolve layering violation. The recorders stay in core/paint.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185263

[trchen, 2014-11-04 03:59:25]

trchen@chromium.org changed reviewers:
+ chrishtr@chromium.org, leviw@chromium.org

[trchen, 2014-11-04 03:59:26]

Hello reviewers,
This CL moves the ViewDisplayList to GraphicsLayer per discussion at
https://codereview.chromium.org/698743002/#msg4 . PTAL!

This WIP breaks unit tests because RenderingTest disables compositing. We may
have to change to higher level test template like WebFrameTest.

[leviw_travelin_and_unemployed, 2014-11-04 04:05:35]

leviw@chromium.org changed reviewers:
+ pdr@chromium.org

[chrishtr, 2014-11-06 02:38:59]

Apologies for the delay. We were all at BlinkOn. I'll get to this tomorrow.

[trchen, 2014-11-06 03:22:01]

No worries! I knew everyone would be extremely busy on BlinkOn. :)

[pdr., 2014-11-06 22:08:23]

This looks great. GraphicsLayer does seem like the appropriate owner for the
display list.

We discussed offline a bit and there was some reluctance to add multiple
inheritance due to the visual studio compiler and empty base classes. Lets
remove the debug code from this patch and add it back in a followup as a String
argument to the constructor. Lets also switch away from multiple inheritance in
favor of a void* pointer. We discussed using a union type but this will not be
possible because platform/ cannot depend on core/.

[Stephen Chennney, 2014-11-06 22:10:17]

On 2014/11/06 22:08:23, pdr wrote:
> This looks great. GraphicsLayer does seem like the appropriate owner for the
> display list.

For now, right, because GraphicsLayer is likely to be the first layer structure
removed.

Still, for now it makes the most sense as this is the origin of painting
commands. I don't even think we know where it will belong eventually, probably
some standalone manager.

> 
> We discussed offline a bit and there was some reluctance to add multiple
> inheritance due to the visual studio compiler and empty base classes. Lets
> remove the debug code from this patch and add it back in a followup as a
String
> argument to the constructor. Lets also switch away from multiple inheritance
in
> favor of a void* pointer. We discussed using a union type but this will not be
> possible because platform/ cannot depend on core/.

[trchen, 2014-11-12 02:12:19]

Hello reviewers,
This CL changes DisplayItemClient to void* as advised, and also make all unit
tests working again. PTAL. Thanks!

[chrishtr, 2014-11-12 17:30:02]

lgtm

[trchen, 2014-11-12 23:41:44]

The CQ bit was checked by trchen@chromium.org

[trchen, 2014-11-12 23:42:04]

The CQ bit was unchecked by trchen@chromium.org

[commit-bot: I haz the power, 2014-11-12 23:42:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/702633002/120001

[trchen, 2014-11-12 23:42:25]

The CQ bit was unchecked by trchen@chromium.org

[trchen, 2014-11-12 23:49:31]

Still need owner review for Source/platform

By the way I just realized by using the invalidation container to determine
which display list to record to, we won't be able to record scrollbar and scroll
corner layers. I think we should bundle DisplayItemList to GraphicsContext. I
will experiment with that as a followup CL.

[trchen, 2014-11-12 23:50:24]

On 2014/11/12 23:49:31, trchen wrote:
> Still need owner review for Source/platform

Oops. Forget it. Chris owns the world. :)

[pdr., 2014-11-13 00:00:44]

On 2014/11/12 at 23:50:24, trchen wrote:
> On 2014/11/12 23:49:31, trchen wrote:
> > Still need owner review for Source/platform
> 
> Oops. Forget it. Chris owns the world. :)

LGTM

[pdr., 2014-11-13 00:00:49]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-11-13 00:01:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/702633002/120001

[trchen, 2014-11-13 01:48:30]

The CQ bit was checked by trchen@chromium.org

[commit-bot: I haz the power, 2014-11-13 01:48:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/702633002/140001

[commit-bot: I haz the power, 2014-11-13 03:33:53]

Committed patchset #8 (id:140001) as 185263

[Peter Beverloo, 2014-11-13 16:44:33]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/724003003/ by peter@chromium.org.

The reason for reverting is: This causes
MultiColumnRenderingTest.SubtreeWithSpannerBeforeSpanner to time out on Android.

BUG=432926.