Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 702623002: Properly restore context when leaving visitor functions in ErrorVerifier. (Closed)

Created:
6 years, 1 month ago by Paul Berry
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Properly restore context when leaving visitor functions in ErrorVerifier. BUG=dartbug.com/15565 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41478

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 1 month ago (2014-11-04 01:28:42 UTC) #2
scheglov
LGTM
6 years, 1 month ago (2014-11-04 01:46:01 UTC) #3
Paul Berry
6 years, 1 month ago (2014-11-04 04:17:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41478 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698