build/common.gypi - Issue 702603004: Renamed DISABLE_BASIC_PRINTING and ENABLE_FULL_PRINTING.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 702603004: Renamed DISABLE_BASIC_PRINTING and ENABLE_FULL_PRINTING. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tue Nov 4 16:01:27 PST 2014 Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 91156ec1e85f9cdcef702490946ac6bbf3b4b1b6..8943e4c283b6c40f7928b59b44b2976116903a17 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -2923,12 +2923,12 @@

# chrome://translate-internals

'defines': ['CLD2_DATA_SOURCE=<(cld2_data_source)'],

}],

- ['enable_printing==1', {

- 'defines': ['ENABLE_FULL_PRINTING=1', 'ENABLE_PRINTING=1'],

- }],

- ['enable_printing==2', {

+ ['enable_printing!=1', {

'defines': ['ENABLE_PRINTING=1'],

}],

+ ['enable_printing==1', {

Lei Zhang 2014/11/05 00:14:45 This doesn't look right. It doesn't mention ENABLE

Vitaly Buka (NO REVIEWS) 2014/11/05 01:22:08 Done.

+ 'defines': ['ENABLE_FULL_PRINTING=1'],

+ }],

['enable_spellcheck==1', {

'defines': ['ENABLE_SPELLCHECK=1'],

}],

« no previous file with comments | « athena/extensions/chrome/athena_chrome_app_delegate.cc ('k') | build/config/BUILD.gn » ('j') | printing/printing_context_win.cc » ('J')