Renamed DISABLE_BASIC_PRINTING and ENABLE_FULL_PRINTING.

build/common.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 2082 matching lines @@
       ['enable_extensions==1', {
         'grit_defines': ['-D', 'enable_extensions'],
       }],
       ['enable_plugins!=0', {
         'grit_defines': ['-D', 'enable_plugins'],
       }],
       ['enable_printing!=0', {
         'grit_defines': ['-D', 'enable_printing'],
       }],
       ['enable_printing==1', {
-        'grit_defines': ['-D', 'enable_full_printing'],
+        'grit_defines': ['-D', 'enable_print_preview'],
       }],
       ['enable_themes==1', {
         'grit_defines': ['-D', 'enable_themes'],
       }],
       ['enable_app_list==1', {
         'grit_defines': ['-D', 'enable_app_list'],
       }],
       ['enable_settings_app==1', {
         'grit_defines': ['-D', 'enable_settings_app'],
       }],
@@ skipping 802 matching lines @@
         'defines': ['ENABLE_GOOGLE_NOW=1'],
       }],
       ['cld_version!=0', {
         'defines': ['CLD_VERSION=<(cld_version)'],
       }],
       ['cld_version==2', {
         # This is used to populate the "CLD Data Source" field in:
         # chrome://translate-internals
         'defines': ['CLD2_DATA_SOURCE=<(cld2_data_source)'],
       }],
+      ['enable_printing!=0', {
+        'defines': ['ENABLE_PRINTING=1', 'ENABLE_BASIC_PRINTING=1'],

[brettw, 2014/11/05 18:02:11]

So does ENABLE_PRINTING have the same meaning as ENABLE_BASIC_PRINTING? If so,
can we search-and-replace to ENABLE_BASIC_PRINTING in a separate patch after
this?

[Vitaly Buka (NO REVIEWS), 2014/11/05 19:14:50]

it's would be ENABLE_PRINTING = (ENABLE_PRINT_PREVIEW || ENABLE_BASIC_PRINTING),
and we can replace this in new patch

Next patch will separate ENABLE_PRINTING and ENABLE_BASIC_PRINTING
I just can't do here because 'enable_printing' has no state for this. 
Check here:
https://codereview.chromium.org/702023002/diff/100001/build/common.gypi#newco...



On 2014/11/05 18:02:11, brettw wrote:

+      }],
       ['enable_printing==1', {
-        'defines': ['ENABLE_FULL_PRINTING=1', 'ENABLE_PRINTING=1'],
-      }],
-      ['enable_printing==2', {
-        'defines': ['ENABLE_PRINTING=1'],
+        'defines': ['ENABLE_PRINT_PREVIEW=1'],
       }],
       ['enable_spellcheck==1', {
         'defines': ['ENABLE_SPELLCHECK=1'],
       }],
       ['enable_captive_portal_detection==1', {
         'defines': ['ENABLE_CAPTIVE_PORTAL_DETECTION=1'],
       }],
       ['enable_app_list==1', {
         'defines': ['ENABLE_APP_LIST=1'],
       }],
@@ skipping 2947 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }