Issue 702523003: bindings: Removes two FIXMEs because setReturnValueFast is useful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 702523003: bindings: Removes two FIXMEs because setReturnValueFast is useful. (Closed)

Created:
6 years, 1 month ago by Yuki

Modified:
6 years, 1 month ago

Reviewers:
haraken

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

bindings: Removes two FIXMEs because setReturnValueFast is useful. I've benchmarked and found that DOMDataStore::setReturnValueFast is quite effective for document.implementation and getElementsByTagName. We should keep this method. BUG=235436 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185175