Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: Source/bindings/core/v8/DOMDataStore.h

Issue 702523003: bindings: Removes two FIXMEs because setReturnValueFast is useful. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/DOMDataStore.h
diff --git a/Source/bindings/core/v8/DOMDataStore.h b/Source/bindings/core/v8/DOMDataStore.h
index 2d6d11b0e504c685502673e8e34a4f70f4a6678f..7ab5ae8a5c8c20c0a3eedb692b982d9cb9176894 100644
--- a/Source/bindings/core/v8/DOMDataStore.h
+++ b/Source/bindings/core/v8/DOMDataStore.h
@@ -65,7 +65,6 @@ public:
{
// The second fastest way to check if we're in the main world is to check if
// the wrappable's wrapper is the same as the holder.
- // FIXME: Investigate if it's worth having this check for performance.
if (holderContainsWrapper(holder, wrappable))
return object->setReturnValue(returnValue);
return current(returnValue.GetIsolate()).setReturnValueFrom(returnValue, object);
@@ -76,7 +75,6 @@ public:
if (canUseScriptWrappable(node)
// The second fastest way to check if we're in the main world is to
// check if the wrappable's wrapper is the same as the holder.
- // FIXME: Investigate if it's worth having this check for performance.
|| holderContainsWrapper(holder, wrappable))
return ScriptWrappable::fromNode(node)->setReturnValue(returnValue);
return current(returnValue.GetIsolate()).setReturnValueFrom(returnValue, ScriptWrappable::fromNode(node));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698