Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: dm/DMJsonWriter.h

Issue 702513003: Separate JSON functions from DMWriteTask. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Remove DM::WriteTask::DumpJson. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dm/DM.cpp ('k') | dm/DMJsonWriter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DMJsonWriter.h
diff --git a/dm/DMJsonWriter.h b/dm/DMJsonWriter.h
new file mode 100644
index 0000000000000000000000000000000000000000..4f75ab8647286eb7a1a139207a202b4d6d079848
--- /dev/null
+++ b/dm/DMJsonWriter.h
@@ -0,0 +1,31 @@
+/*
+ * Copyright 2014 Google Inc.
+ *
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+#ifndef DMJsonWriter_DEFINED
+#define DMJsonWriter_DEFINED
+
+#include "SkString.h"
+
+namespace DM {
+
+class JsonWriter {
+public:
+ struct GmData {
mtklein 2014/11/04 13:53:23 This guy can be a little more general than GmData.
scroggo 2014/11/04 15:01:52 Done.
+ SkString name; // E.g. "ninepatch-stretch", "desk-gws_skp"
+ SkString config; // "gpu", "8888"
+ SkString mode; // "direct", "default-tilegrid", "pipe"
+ SkString sourceType; // "GM", "SKP"
+ SkString md5; // In ASCII, so 32 bytes long.
+ };
+
+ static void AddGmData(GmData data);
mtklein 2014/11/04 13:53:23 Can you add a note like // All methods thread-safe
scroggo 2014/11/04 15:01:52 Done.
+
+ static void DumpJson();
+};
+
+} // namespace DM
+#endif // DMJsonWriter_DEFINED
« no previous file with comments | « dm/DM.cpp ('k') | dm/DMJsonWriter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698