Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: dm/DMJsonWriter.h

Issue 702513003: Separate JSON functions from DMWriteTask. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Remove DM::WriteTask::DumpJson. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « dm/DM.cpp ('k') | dm/DMJsonWriter.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 /*
2 * Copyright 2014 Google Inc.
3 *
4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file.
6 */
7
8 #ifndef DMJsonWriter_DEFINED
9 #define DMJsonWriter_DEFINED
10
11 #include "SkString.h"
12
13 namespace DM {
14
15 class JsonWriter {
16 public:
17 struct GmData {
mtklein 2014/11/04 13:53:23 This guy can be a little more general than GmData.
scroggo 2014/11/04 15:01:52 Done.
18 SkString name; // E.g. "ninepatch-stretch", "desk-gws_skp"
19 SkString config; // "gpu", "8888"
20 SkString mode; // "direct", "default-tilegrid", "pipe"
21 SkString sourceType; // "GM", "SKP"
22 SkString md5; // In ASCII, so 32 bytes long.
23 };
24
25 static void AddGmData(GmData data);
mtklein 2014/11/04 13:53:23 Can you add a note like // All methods thread-safe
scroggo 2014/11/04 15:01:52 Done.
26
27 static void DumpJson();
28 };
29
30 } // namespace DM
31 #endif // DMJsonWriter_DEFINED
OLDNEW
« no previous file with comments | « dm/DM.cpp ('k') | dm/DMJsonWriter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698