Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 702513003: Separate JSON functions from DMWriteTask. (Closed)

Created:
6 years, 1 month ago by scroggo
Modified:
6 years, 1 month ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Separate JSON functions from DMWriteTask. Add JsonWriter, which handles Json output from DM, in preparation for adding json output for tests. This change should not affect behavior. BUG=skia:2454 Committed: https://skia.googlesource.com/skia/+/7a10fb6bead0f63623307a7ff71b1dd323534a7f

Patch Set 1 #

Patch Set 2 : Remove DM::WriteTask::DumpJson. #

Total comments: 4

Patch Set 3 : Respond to comments. Pass by const ref #

Patch Set 4 : Modify comment to be more accurate. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -52 lines) Patch
M dm/DM.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A dm/DMJsonWriter.h View 1 2 3 1 chunk +44 lines, -0 lines 0 comments Download
A dm/DMJsonWriter.cpp View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
M dm/DMWriteTask.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M dm/DMWriteTask.cpp View 1 2 4 chunks +7 lines, -47 lines 0 comments Download
M gyp/dm.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scroggo
6 years, 1 month ago (2014-11-04 03:31:58 UTC) #2
mtklein
lgtm, just some nits https://codereview.chromium.org/702513003/diff/20001/dm/DMJsonWriter.h File dm/DMJsonWriter.h (right): https://codereview.chromium.org/702513003/diff/20001/dm/DMJsonWriter.h#newcode17 dm/DMJsonWriter.h:17: struct GmData { This guy ...
6 years, 1 month ago (2014-11-04 13:53:23 UTC) #3
scroggo
https://codereview.chromium.org/702513003/diff/20001/dm/DMJsonWriter.h File dm/DMJsonWriter.h (right): https://codereview.chromium.org/702513003/diff/20001/dm/DMJsonWriter.h#newcode17 dm/DMJsonWriter.h:17: struct GmData { On 2014/11/04 13:53:23, mtklein wrote: > ...
6 years, 1 month ago (2014-11-04 15:01:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702513003/60001
6 years, 1 month ago (2014-11-04 15:13:07 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 15:21:15 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as 7a10fb6bead0f63623307a7ff71b1dd323534a7f

Powered by Google App Engine
This is Rietveld 408576698