Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 702493002: PepperGL: Enable client side arrays support. (Closed)

Created:
6 years, 1 month ago by Peng
Modified:
6 years, 1 month ago
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

PepperGL: Enable client side arrays support. Currently, the client side arrays feature is controlled by a compile flag. And the flag is only defined in nacl build. This change uses a variable to control it. So we could enable it in runtime. BUG=429179 Committed: https://crrev.com/5527fa12043d5c268b31e3744e2e03d86b7e8231 Cr-Commit-Position: refs/heads/master@{#302478}

Patch Set 1 #

Patch Set 2 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -100 lines) Patch
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M gpu/BUILD.gn View 3 chunks +2 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/BUILD.gn View 1 chunk +0 lines, -25 lines 0 comments Download
M gpu/command_buffer/client/gl_in_process_context.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 2 chunks +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 7 chunks +11 lines, -22 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/vertex_array_object_manager.h View 2 chunks +4 lines, -1 line 0 comments Download
M gpu/command_buffer/client/vertex_array_object_manager.cc View 7 chunks +8 lines, -14 lines 0 comments Download
M gpu/command_buffer/client/vertex_array_object_manager_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M gpu/gles2_conform_support/gles2_conform_support.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gpu/gpu.gyp View 4 chunks +4 lines, -29 lines 0 comments Download
M ppapi/shared_impl/ppb_graphics_3d_shared.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Peng
Hi David & Antoine, PTAL. Thanks.
6 years, 1 month ago (2014-11-03 17:07:17 UTC) #2
piman
lgtm
6 years, 1 month ago (2014-11-03 19:52:10 UTC) #3
dmichael (off chromium)
ppapi lgtm
6 years, 1 month ago (2014-11-03 20:06:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702493002/20001
6 years, 1 month ago (2014-11-03 20:14:14 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-03 21:05:43 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 21:06:52 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5527fa12043d5c268b31e3744e2e03d86b7e8231
Cr-Commit-Position: refs/heads/master@{#302478}

Powered by Google App Engine
This is Rietveld 408576698