On Views, track all opens of the menu from icon AND bubble. Matches Mac.

On Views, track all opens of the menu from icon AND bubble. Matches Mac.

Currently, this metric on cocoa tracks opening the user menu from the
icon or bubble, but on Views only from the icon. We want to also track
opening the new User Menu in Views with this stat.

BUG=NONE

Committed: https://crrev.com/fdb176eb579c872f4c4f67f5ae050264900459aa
Cr-Commit-Position: refs/heads/master@{#302469}

[Mike Lerman, 2014-11-03 15:12:45]

mlerman@chromium.org changed reviewers:
+ jwd@chromium.org, noms@chromium.org, sky@chromium.org

[Mike Lerman, 2014-11-03 15:12:50]

Hi, please review this little CL. It wants your love!

sky - c/b/ui/views/frame owner
noms - keep me honest about User Menu things
jwd - owner of histograms.xml

Thanks!

[noms (inactive), 2014-11-03 15:18:52]

lgtm with phrasing nits.

https://codereview.chromium.org/702483002/diff/1/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_metrics.h (right):

https://codereview.chromium.org/702483002/diff/1/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_metrics.h:53: ICON_AVATAR_BUBBLE,       // User
opens avatar icon menu from icon or button
nit: i would call this the "avatar menu" not the "avatar icon menu" and just
call it the avatar button. So "User opens the avatar menu from the avatar
button". And change the above "Avatar icon menu" to "avatar menu" as well.
Avatar menu bubble is also ok if you like that :)

https://codereview.chromium.org/702483002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/702483002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:51572: +  <int value="1" label="Opened
the avatar bubble menu from icon or button"/>
nit: make this consistent with the above, so something like "Opened the avatar
menu from the avatar button"

[Mike Lerman, 2014-11-03 15:32:07]

https://codereview.chromium.org/702483002/diff/1/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_metrics.h (right):

https://codereview.chromium.org/702483002/diff/1/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_metrics.h:53: ICON_AVATAR_BUBBLE,       // User
opens avatar icon menu from icon or button
On 2014/11/03 15:18:52, Monica Dinculescu wrote:
> nit: i would call this the "avatar menu" not the "avatar icon menu" and just
> call it the avatar button. So "User opens the avatar menu from the avatar
> button". And change the above "Avatar icon menu" to "avatar menu" as well.
> Avatar menu bubble is also ok if you like that :)

Done.

https://codereview.chromium.org/702483002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/702483002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:51572: +  <int value="1" label="Opened
the avatar bubble menu from icon or button"/>
On 2014/11/03 15:18:52, Monica Dinculescu wrote:
> nit: make this consistent with the above, so something like "Opened the avatar
> menu from the avatar button"

Like dinner.

[sky, 2014-11-03 16:41:26]

LGTM

[jwd, 2014-11-03 18:50:10]

lgtm

[Mike Lerman, 2014-11-03 18:50:29]

The CQ bit was checked by mlerman@chromium.org

[commit-bot: I haz the power, 2014-11-03 18:51:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/702483002/20001

[commit-bot: I haz the power, 2014-11-03 19:53:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-03 19:54:30]

Patchset 2 (id:??) landed as
https://crrev.com/fdb176eb579c872f4c4f67f5ae050264900459aa
Cr-Commit-Position: refs/heads/master@{#302469}