chrome/browser/ui/views/frame/browser_view.cc - Issue 702483002: On Views, track all opens of the menu from icon AND bubble. Matches Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 702483002: On Views, track all opens of the menu from icon AND bubble. Matches Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: noms nits Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 2fcd6cd00ca6ae5542e909ce6f7c5cc2794060a4..741a976b473d1f7cda130e6145ed4abb25c33c6a 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -2431,8 +2431,8 @@ void BrowserView::ShowAvatarBubbleFromAvatarButton(

views::BubbleBorder::PAINT_NORMAL;

AvatarMenuBubbleView::ShowBubble(anchor_view, arrow, arrow_paint_type,

alignment, bounds, browser());

- ProfileMetrics::LogProfileOpenMethod(ProfileMetrics::ICON_AVATAR_BUBBLE);

}

+ ProfileMetrics::LogProfileOpenMethod(ProfileMetrics::ICON_AVATAR_BUBBLE);

}

int BrowserView::GetRenderViewHeightInsetWithDetachedBookmarkBar() {

« no previous file with comments | « chrome/browser/profiles/profile_metrics.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »