extensions/shell/renderer/shell_content_renderer_client.h - Issue 702433002: Refactor GuestViewContainer to split out WebView related logic and MimeHandlerView related logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/renderer/shell_content_renderer_client.h

Issue 702433002: Refactor GuestViewContainer to split out WebView related logic and MimeHandlerView related logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/guest_view/web_view_container.h ('K') | « extensions/renderer/guest_view/web_view_container.cc ('k') | extensions/shell/renderer/shell_content_renderer_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/shell/renderer/shell_content_renderer_client.h

diff --git a/extensions/shell/renderer/shell_content_renderer_client.h b/extensions/shell/renderer/shell_content_renderer_client.h

index a4df9ca25a91eeb4becb70bce0f265c0aec3b8f6..46c3611a5805d98a22a02019d1bb6ad0c505f0ab 100644

--- a/extensions/shell/renderer/shell_content_renderer_client.h

+++ b/extensions/shell/renderer/shell_content_renderer_client.h

@@ -47,7 +47,9 @@ class ShellContentRendererClient : public content::ContentRendererClient {

const void* CreatePPAPIInterface(const std::string& interface_name) override;

bool IsExternalPepperPlugin(const std::string& module_name) override;

bool ShouldEnableSiteIsolationPolicy() const override;

- content::BrowserPluginDelegate* CreateBrowserPluginDelegate(

+ content::BrowserPluginDelegate* CreateWebViewContainer(

+ content::RenderFrame* render_frame) override;

+ content::BrowserPluginDelegate* CreateMimeHandlerViewContainer(

content::RenderFrame* render_frame,

const std::string& mime_type) override;