Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: extensions/shell/renderer/shell_content_renderer_client.cc

Issue 702433002: Refactor GuestViewContainer to split out WebView related logic and MimeHandlerView related logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/shell/renderer/shell_content_renderer_client.cc
diff --git a/extensions/shell/renderer/shell_content_renderer_client.cc b/extensions/shell/renderer/shell_content_renderer_client.cc
index 487731d93cad67a7b4f5321fe6fed172c311116a..8e3c19518a83f21a75cff04b7299b7900caf9a7e 100644
--- a/extensions/shell/renderer/shell_content_renderer_client.cc
+++ b/extensions/shell/renderer/shell_content_renderer_client.cc
@@ -12,7 +12,8 @@
#include "extensions/renderer/default_dispatcher_delegate.h"
#include "extensions/renderer/dispatcher.h"
#include "extensions/renderer/extension_helper.h"
-#include "extensions/renderer/guest_view/guest_view_container.h"
+#include "extensions/renderer/guest_view/mime_handler_view_container.h"
+#include "extensions/renderer/guest_view/web_view_container.h"
#include "extensions/shell/common/shell_extensions_client.h"
#include "extensions/shell/renderer/shell_extensions_renderer_client.h"
#include "third_party/WebKit/public/web/WebLocalFrame.h"
@@ -175,10 +176,16 @@ bool ShellContentRendererClient::ShouldEnableSiteIsolationPolicy() const {
}
content::BrowserPluginDelegate*
-ShellContentRendererClient::CreateBrowserPluginDelegate(
+ShellContentRendererClient::CreateWebViewContainer(
+ content::RenderFrame* render_frame) {
+ return new extensions::WebViewContainer(render_frame);
+}
+
+content::BrowserPluginDelegate*
+ShellContentRendererClient::CreateMimeHandlerViewContainer(
content::RenderFrame* render_frame,
const std::string& mime_type) {
- return new extensions::GuestViewContainer(render_frame, mime_type);
+ return new extensions::MimeHandlerViewContainer(render_frame, mime_type);
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698