Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 702433002: Refactor GuestViewContainer to split out WebView related logic and MimeHandlerView related logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 2eac475be064c24716545f33a782386ba495be9a..6be041af7b5dd727cbb0d4afa019790b8c4ac9d0 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -1617,8 +1617,7 @@ blink::WebPlugin* RenderFrameImpl::createPlugin(
if (base::UTF16ToUTF8(params.mimeType) == kBrowserPluginMimeType) {
scoped_ptr<BrowserPluginDelegate> browser_plugin_delegate(
- GetContentClient()->renderer()->CreateBrowserPluginDelegate(
- this, std::string()));
+ GetContentClient()->renderer()->CreateWebViewContainer(this));
Fady Samuel 2014/11/03 11:03:37 Please restore.
raymes 2014/11/03 22:51:31 Done.
return render_view_->GetBrowserPluginManager()->CreateBrowserPlugin(
render_view_.get(), frame, browser_plugin_delegate.Pass());
}
@@ -1635,7 +1634,7 @@ blink::WebPlugin* RenderFrameImpl::createPlugin(
if (info.type == content::WebPluginInfo::PLUGIN_TYPE_BROWSER_PLUGIN) {
scoped_ptr<BrowserPluginDelegate> browser_plugin_delegate(
- GetContentClient()->renderer()->CreateBrowserPluginDelegate(
+ GetContentClient()->renderer()->CreateMimeHandlerViewContainer(
Fady Samuel 2014/11/03 11:03:37 Please restore.
raymes 2014/11/03 22:51:31 Done.
this, base::UTF16ToUTF8(params.mimeType)));
return render_view_->GetBrowserPluginManager()->CreateBrowserPlugin(
render_view_.get(), frame, browser_plugin_delegate.Pass());

Powered by Google App Engine
This is Rietveld 408576698