content/public/renderer/content_renderer_client.h - Issue 702433002: Refactor GuestViewContainer to split out WebView related logic and MimeHandlerView related logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/renderer/content_renderer_client.h

Issue 702433002: Refactor GuestViewContainer to split out WebView related logic and MimeHandlerView related logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/chrome_content_renderer_client.cc ('K') | « content/public/renderer/browser_plugin_delegate.h ('k') | content/public/renderer/content_renderer_client.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/renderer/content_renderer_client.h

diff --git a/content/public/renderer/content_renderer_client.h b/content/public/renderer/content_renderer_client.h

index daf8d4a650d7212d3725d12dc7160a71f17cc332..52b32e90f87dd294d88b60d825bee18e5eee772e 100644

--- a/content/public/renderer/content_renderer_client.h

+++ b/content/public/renderer/content_renderer_client.h

@@ -102,8 +102,10 @@ class CONTENT_EXPORT ContentRendererClient {

RenderFrame* render_frame,

const base::FilePath& plugin_path);

- // Creates a delegate for browser plugin.

- virtual BrowserPluginDelegate* CreateBrowserPluginDelegate(

+ // Create delegates for browser plugin.

+ virtual BrowserPluginDelegate* CreateWebViewContainer(

Fady Samuel 2014/11/03 11:03:37 This exposes the concept of WebView to the content

raymes 2014/11/03 22:51:31 Done.

+ RenderFrame* render_frame);

+ virtual BrowserPluginDelegate* CreateMimeHandlerViewContainer(

RenderFrame* render_frame,

const std::string& mime_type);