Refactor GuestViewContainer to split out WebView related logic and MimeHandlerView related logic.

content/public/renderer/content_renderer_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_CONTENT_RENDERER_CLIENT_H_
 #define CONTENT_PUBLIC_RENDERER_CONTENT_RENDERER_CLIENT_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 84 matching lines @@
       blink::WebLocalFrame* frame,
       const blink::WebPluginParams& params,
       blink::WebPlugin** plugin);
 
   // Creates a replacement plug-in that is shown when the plug-in at |file_path|
   // couldn't be loaded. This allows the embedder to show a custom placeholder.
   virtual blink::WebPlugin* CreatePluginReplacement(
       RenderFrame* render_frame,
       const base::FilePath& plugin_path);
 
-  // Creates a delegate for browser plugin.
-  virtual BrowserPluginDelegate* CreateBrowserPluginDelegate(
+  // Create delegates for browser plugin.
+  virtual BrowserPluginDelegate* CreateWebViewContainer(

[Fady Samuel, 2014/11/03 11:03:37]

This exposes the concept of WebView to the content module which is not
appropriate. Please restore the code here.

[raymes, 2014/11/03 22:51:31]

Done.

+      RenderFrame* render_frame);
+  virtual BrowserPluginDelegate* CreateMimeHandlerViewContainer(
       RenderFrame* render_frame,
       const std::string& mime_type);
 
   // Returns true if the embedder has an error page to show for the given http
   // status code. If so |error_domain| should be set to according to WebURLError
   // and the embedder's GetNavigationErrorHtml will be called afterwards to get
   // the error html.
   virtual bool HasErrorPage(int http_status_code,
                             std::string* error_domain);
 
@@ skipping 158 matching lines @@
   virtual bool IsPluginAllowedToUseDevChannelAPIs();
 
   // Returns a user agent override specific for |url|, or empty string if
   // default user agent should be used.
   virtual std::string GetUserAgentOverrideForURL(const GURL& url);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_RENDERER_CONTENT_RENDERER_CLIENT_H_