Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: chrome/chrome_browser.gypi

Issue 702023002: Renamed enable_printing and printing_mode in *.gyp* and .*gn* files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Wed Nov 5 03:20:34 PST 2014 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_browser.gypi
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index a7a91ad3a22243b3469ba4626ef27b2d25cede65..9dd237221ed35c6226a508147f631e6167747f1c 100644
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -1824,7 +1824,7 @@
'browser/themes/theme_syncable_service.cc',
'browser/themes/theme_syncable_service.h',
],
- # Used both when enable_printing == 1 (full) and == 2 (basic)
+ # Used both when (enable_basic_printing==1 or enable_print_preview==1).
'chrome_browser_basic_printing_sources': [
'browser/printing/print_job.cc',
'browser/printing/print_job.h',
@@ -1841,7 +1841,7 @@
'browser/printing/printing_message_filter.cc',
'browser/printing/printing_message_filter.h',
],
- # Used on top of the "basic" sources when enable_printing == 1 (full).
+ # Used on top of the "basic" sources when enable_print_preview==1.
'chrome_browser_full_printing_sources': [
'browser/local_discovery/pwg_raster_converter.cc',
'browser/local_discovery/pwg_raster_converter.h',
@@ -1876,7 +1876,7 @@
'browser/task_manager/printing_information.cc',
'browser/task_manager/printing_information.h',
],
- # Used only in basic printing (enable_printing == 2) mode.
+ # Used only in (enable_basic_printing==1 and enable_print_preview==0) mode.
'chrome_browser_basic_only_printing_sources': [
'browser/printing/print_view_manager_basic.cc',
'browser/printing/print_view_manager_basic.h',
@@ -3250,7 +3250,7 @@
'sources': [ '<@(chrome_browser_themes_sources)' ],
}],
# Some form of printing support.
- ['enable_printing!=0', {
+ ['enable_basic_printing==1 or enable_print_preview==1', {
'dependencies': [
'../printing/printing.gyp:printing',
],
@@ -3259,16 +3259,16 @@
['OS=="win"', {
'sources': [ '<@(chrome_browser_printing_emf_sources)' ],
}],
- # Full printing on top of the above.
- ['enable_printing==1', {
- 'sources': [ '<@(chrome_browser_full_printing_sources)' ],
- }],
- # Partial-only printing support.
- ['enable_printing==2', {
- 'sources': [ '<@(chrome_browser_basic_only_printing_sources)' ],
- }],
],
}],
+ # Full printing on top of the above.
+ ['enable_print_preview==1', {
+ 'sources': [ '<@(chrome_browser_full_printing_sources)' ],
+ }],
+ # Partial-only printing support.
+ ['enable_basic_printing==1 and enable_print_preview==0', {
+ 'sources': [ '<@(chrome_browser_basic_only_printing_sources)' ],
+ }],
['enable_captive_portal_detection==1', {
'sources': [ '<@(chrome_browser_captive_portal_sources)' ]
}],
« chrome/BUILD.gn ('K') | « chrome/chrome.gyp ('k') | chrome/chrome_browser_chromeos.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698