Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5047)

Unified Diff: chrome/BUILD.gn

Issue 702023002: Renamed enable_printing and printing_mode in *.gyp* and .*gn* files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Wed Nov 5 03:20:34 PST 2014 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index ad58f0642a354f9204adb46dfbb0832532d2bb9f..619e617d32e5f116b7f43af0b64c7027d50c58b3 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -218,9 +218,9 @@ group("browser_dependencies") {
]
}
- if (printing_mode != 0) {
+ if (enable_basic_printing || enable_print_preview) {
brettw 2014/11/05 18:02:52 Can we require that enable_print_preview implies b
Vitaly Buka (NO REVIEWS) 2014/11/05 19:17:47 No. We will disable basic printing on ChromeOS now
deps += [ "//printing" ]
- if (printing_mode == 1) {
+ if (enable_print_preview) {
deps += [ "//chrome/service" ]
}
}

Powered by Google App Engine
This is Rietveld 408576698