Renamed enable_printing and printing_mode in *.gyp* and .*gn* files.

Renamed enable_printing and printing_mode in *.gyp* and .*gn* files.

enable_printing and printing_mode replaced with
enable_basic_printing and enable_print_preview.

BUG=430281
Committed: https://crrev.com/93eea40972717ac4e0a649bd289fc9e946512c33
Cr-Commit-Position: refs/heads/master@{#302905}

[Vitaly Buka (NO REVIEWS), 2014-11-05 08:19:11]

vitalybuka@chromium.org changed reviewers:
+ brettw@chromium.org, thestig@chromium.org

[Lei Zhang, 2014-11-05 10:07:38]

lgtm

[brettw, 2014-11-05 18:02:52]

https://codereview.chromium.org/702023002/diff/100001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/702023002/diff/100001/build/common.gypi#newco...
build/common.gypi:493: # Enable printing with print preview.
Can you comment here "requires basic printing to be enabled".

https://codereview.chromium.org/702023002/diff/100001/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/702023002/diff/100001/chrome/BUILD.gn#newcode221
chrome/BUILD.gn:221: if (enable_basic_printing || enable_print_preview) {
Can we require that enable_print_preview implies basic printing to simplify
these conditionals>?

[Vitaly Buka (NO REVIEWS), 2014-11-05 19:17:48]

https://codereview.chromium.org/702023002/diff/100001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/702023002/diff/100001/build/common.gypi#newco...
build/common.gypi:493: # Enable printing with print preview.
On 2014/11/05 18:02:52, brettw wrote:
> Can you comment here "requires basic printing to be enabled".

It does not. The point is to have them independent.

https://codereview.chromium.org/702023002/diff/100001/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/702023002/diff/100001/chrome/BUILD.gn#newcode221
chrome/BUILD.gn:221: if (enable_basic_printing || enable_print_preview) {
On 2014/11/05 18:02:52, brettw wrote:
> Can we require that enable_print_preview implies basic printing to simplify
> these conditionals>?

No. We will disable basic printing on ChromeOS now, and maybe on other desktops
in future.

[Vitaly Buka (NO REVIEWS), 2014-11-05 19:20:31]

On 2014/11/05 19:17:48, Vitaly Buka wrote:
> https://codereview.chromium.org/702023002/diff/100001/build/common.gypi
> File build/common.gypi (right):
> 
>
https://codereview.chromium.org/702023002/diff/100001/build/common.gypi#newco...
> build/common.gypi:493: # Enable printing with print preview.
> On 2014/11/05 18:02:52, brettw wrote:
> > Can you comment here "requires basic printing to be enabled".
> 
> It does not. The point is to have them independent.
> 
> https://codereview.chromium.org/702023002/diff/100001/chrome/BUILD.gn
> File chrome/BUILD.gn (right):
> 
>
https://codereview.chromium.org/702023002/diff/100001/chrome/BUILD.gn#newcode221
> chrome/BUILD.gn:221: if (enable_basic_printing || enable_print_preview) {
> On 2014/11/05 18:02:52, brettw wrote:
> > Can we require that enable_print_preview implies basic printing to simplify
> > these conditionals>?
> 
> No. We will disable basic printing on ChromeOS now, and maybe on other
desktops
> in future.

We still can have enable_printing as (enable_basic_printing ||
enable_print_preview).
But I'd prefer less vars and more verbose conditions here. Some of them with
little changes may
become just either enable_basic_printing or enable_print_preview.

[brettw, 2014-11-05 19:25:23]

lgtm

https://codereview.chromium.org/702023002/diff/100001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/702023002/diff/100001/build/common.gypi#newco...
build/common.gypi:493: # Enable printing with print preview.
On 2014/11/05 19:17:47, Vitaly Buka wrote:
> On 2014/11/05 18:02:52, brettw wrote:
> > Can you comment here "requires basic printing to be enabled".
> 
> It does not. The point is to have them independent.

Can you comment about that explicitly here then? Just reading this, I would have
expected preview to imply basic.

https://codereview.chromium.org/702023002/diff/100001/build/common.gypi#newco...
build/common.gypi:2930: 'defines': ['ENABLE_PRINTING=1'],
Can you also comment in common.gypi and in the GN file where these defines are
set what exactly they mean, being sure to mention that print preview doesn't
imply basic printing.

You can do this in either of these two patches, whichever is more convenient.

[brettw, 2014-11-05 19:25:27]

lgtm

[Vitaly Buka (NO REVIEWS), 2014-11-05 21:50:04]

https://codereview.chromium.org/702023002/diff/100001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/702023002/diff/100001/build/common.gypi#newco...
build/common.gypi:493: # Enable printing with print preview.
On 2014/11/05 19:25:23, brettw wrote:
> On 2014/11/05 19:17:47, Vitaly Buka wrote:
> > On 2014/11/05 18:02:52, brettw wrote:
> > > Can you comment here "requires basic printing to be enabled".
> > 
> > It does not. The point is to have them independent.
> 
> Can you comment about that explicitly here then? Just reading this, I would
have
> expected preview to imply basic.

Done.

https://codereview.chromium.org/702023002/diff/100001/build/common.gypi#newco...
build/common.gypi:2930: 'defines': ['ENABLE_PRINTING=1'],
On 2014/11/05 19:25:23, brettw wrote:
> Can you also comment in common.gypi and in the GN file where these defines are
> set what exactly they mean, being sure to mention that print preview doesn't
> imply basic printing.
> 
> You can do this in either of these two patches, whichever is more convenient. 

Done.

[Vitaly Buka (NO REVIEWS), 2014-11-05 21:50:20]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-11-05 21:51:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/702023002/190001

[commit-bot: I haz the power, 2014-11-05 23:47:24]

Committed patchset #11 (id:190001)

[commit-bot: I haz the power, 2014-11-05 23:48:13]

Patchset 11 (id:??) landed as
https://crrev.com/93eea40972717ac4e0a649bd289fc9e946512c33
Cr-Commit-Position: refs/heads/master@{#302905}