Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 702003004: Rename PushPermissionCallback to PushPermissionStatusCallback [1/3] (Closed)

Created:
6 years, 1 month ago by Michael van Ouwerkerk
Modified:
6 years, 1 month ago
Reviewers:
Mike West
CC:
blink-reviews, dglazkov+blink
Project:
blink
Visibility:
Public.

Description

Rename PushPermissionCallback to PushPermissionStatusCallback [1/3] Patch dependency: [1] Blink: https://crrev.com/702003004/ (THIS PATCH) [2] Chromium: https://crrev.com/690833004/ [3] Blink: https://crrev.com/708543002/ BUG=430527 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184906

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -114 lines) Patch
M Source/modules/modules.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/push_messaging/PushManager.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
D Source/modules/push_messaging/PushPermissionCallback.h View 1 chunk +0 lines, -42 lines 0 comments Download
D Source/modules/push_messaging/PushPermissionCallback.cpp View 1 chunk +0 lines, -53 lines 0 comments Download
A + Source/modules/push_messaging/PushPermissionStatusCallback.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + Source/modules/push_messaging/PushPermissionStatusCallback.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M public/platform/WebPushClient.h View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael van Ouwerkerk
Hi Mike, could you please take a look? Thanks!
6 years, 1 month ago (2014-11-05 17:28:03 UTC) #2
Mike West
LGTM
6 years, 1 month ago (2014-11-05 18:36:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702003004/1
6 years, 1 month ago (2014-11-06 10:50:36 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 10:52:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184906

Powered by Google App Engine
This is Rietveld 408576698