Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Unified Diff: public/platform/WebPushClient.h

Issue 702003004: Rename PushPermissionCallback to PushPermissionStatusCallback [1/3] (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/push_messaging/PushPermissionStatusCallback.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebPushClient.h
diff --git a/public/platform/WebPushClient.h b/public/platform/WebPushClient.h
index 71be9dc8b59f66d4d8c177534219e048355c5cd5..853655dc22bb0987c4eaf319533630c89201295d 100644
--- a/public/platform/WebPushClient.h
+++ b/public/platform/WebPushClient.h
@@ -15,7 +15,9 @@ class WebServiceWorkerProvider;
struct WebPushRegistration;
typedef WebCallbacks<WebPushRegistration, WebPushError> WebPushRegistrationCallbacks;
+// FIXME: Delete WebPushPermissionCallback once the embedder stops depending on it.
typedef WebCallbacks<WebPushPermissionStatus, void> WebPushPermissionCallback;
+typedef WebCallbacks<WebPushPermissionStatus, void> WebPushPermissionStatusCallback;
class WebPushClient {
public:
@@ -25,9 +27,9 @@ public:
// client. Ownership of the WebServiceWorkerProvider is not transferred.
virtual void registerPushMessaging(WebPushRegistrationCallbacks*, WebServiceWorkerProvider*) { }
- // Ownership of the WebPushPermissionCallback is transferred to the
+ // Ownership of the WebPushPermissionStatusCallback is transferred to the
// client. Ownership of the WebServiceWorkerProvider is not transferred.
- virtual void getPermissionStatus(WebPushPermissionCallback*, WebServiceWorkerProvider*) { }
+ virtual void getPermissionStatus(WebPushPermissionStatusCallback*, WebServiceWorkerProvider*) { }
};
} // namespace blink
« no previous file with comments | « Source/modules/push_messaging/PushPermissionStatusCallback.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698