This gets at least a chunk of the Mac GN build working.
With a few additional fixes in other repos, we will have substantially more working, but this'll do to at least make the bots functional.
R=brettw@chromium.org
BUG=431117
Committed: https://crrev.com/cf8465db79634a28bdf66c8c518fccddf3af1ee9
Cr-Commit-Position: refs/heads/master@{#303540}
lgtm https://codereview.chromium.org/702003002/diff/180001/mojo/services/html_viewer/BUILD.gn File mojo/services/html_viewer/BUILD.gn (right): https://codereview.chromium.org/702003002/diff/180001/mojo/services/html_viewer/BUILD.gn#newcode7 mojo/services/html_viewer/BUILD.gn:7: if (!is_mac) { If the mac build sees ...
https://codereview.chromium.org/702003002/diff/180001/mojo/services/html_view...
File mojo/services/html_viewer/BUILD.gn (right):
https://codereview.chromium.org/702003002/diff/180001/mojo/services/html_view...
mojo/services/html_viewer/BUILD.gn:7: if (!is_mac) {
On 2014/11/10 07:01:29, brettw wrote:
> If the mac build sees this file at all, then that means a target in this file
> was referenced, and since there are no targets here it will fail with an
> unresolved target. If the build passes, it would seem that this file is never
> referenced.
I think I may have commented this out in order to figure out which file was
referencing it, and then removed the reference (in mojo/services/BUILD.gn).
I'll verify that's the case and revert this change if I can.
Issue 702003002: Make *some* version of the Mac GN build work.
(Closed)
Created 6 years, 1 month ago by Dirk Pranke
Modified 6 years, 1 month ago
Reviewers: brettw
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 2