Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 702003002: Make *some* version of the Mac GN build work. (Closed)

Created:
6 years, 1 month ago by Dirk Pranke
Modified:
6 years, 1 month ago
Reviewers:
brettw
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, cbentzel+watch_chromium.org, Dai Mikurube (NOT FULLTIME), qsr+mojo_chromium.org, Aaron Boodman, wfh+watch_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin-cc_chromium.org, tfarina, mkwst+moarreviews-shell_chromium.org, erikwright+watch_chromium.org, ben+mojo_chromium.org, darin (slow to review), jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

This gets at least a chunk of the Mac GN build working. With a few additional fixes in other repos, we will have substantially more working, but this'll do to at least make the bots functional. R=brettw@chromium.org BUG=431117 Committed: https://crrev.com/cf8465db79634a28bdf66c8c518fccddf3af1ee9 Cr-Commit-Position: refs/heads/master@{#303540}

Patch Set 1 #

Patch Set 2 : work in progress #

Patch Set 3 : skip breakpad:symupload #

Patch Set 4 : fix html_viewer and dynamic_images #

Patch Set 5 : merge to r303329 #

Patch Set 6 : clean up changes #

Patch Set 7 : fix typo #

Patch Set 8 : fix typo, disable sandbox #

Patch Set 9 : fix duplicate symbols from aura #

Patch Set 10 : merge to r303398 (after win gn CL landed) #

Total comments: 2

Patch Set 11 : revert html_viewer/BUILD.gn change #

Patch Set 12 : fix harfbuzz clause on non-linux platforms #

Patch Set 13 : skip //chrome/tests on mac and win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -9 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +63 lines, -1 line 0 comments Download
M breakpad/BUILD.gn View 1 2 3 4 5 3 chunks +13 lines, -4 lines 0 comments Download
M mojo/services/BUILD.gn View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M net/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +3 lines, -2 lines 0 comments Download
M sandbox/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +4 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +3 lines, -1 line 0 comments Download
M ui/base/BUILD.gn View 1 2 3 4 5 6 7 8 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Dirk Pranke
6 years, 1 month ago (2014-11-10 03:41:11 UTC) #2
brettw
lgtm https://codereview.chromium.org/702003002/diff/180001/mojo/services/html_viewer/BUILD.gn File mojo/services/html_viewer/BUILD.gn (right): https://codereview.chromium.org/702003002/diff/180001/mojo/services/html_viewer/BUILD.gn#newcode7 mojo/services/html_viewer/BUILD.gn:7: if (!is_mac) { If the mac build sees ...
6 years, 1 month ago (2014-11-10 07:01:29 UTC) #3
Dirk Pranke
https://codereview.chromium.org/702003002/diff/180001/mojo/services/html_viewer/BUILD.gn File mojo/services/html_viewer/BUILD.gn (right): https://codereview.chromium.org/702003002/diff/180001/mojo/services/html_viewer/BUILD.gn#newcode7 mojo/services/html_viewer/BUILD.gn:7: if (!is_mac) { On 2014/11/10 07:01:29, brettw wrote: > ...
6 years, 1 month ago (2014-11-10 17:46:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702003002/240001
6 years, 1 month ago (2014-11-10 23:06:59 UTC) #6
commit-bot: I haz the power
Committed patchset #13 (id:240001)
6 years, 1 month ago (2014-11-10 23:51:33 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 23:52:13 UTC) #8
Message was sent while issue was closed.
Patchset 13 (id:??) landed as
https://crrev.com/cf8465db79634a28bdf66c8c518fccddf3af1ee9
Cr-Commit-Position: refs/heads/master@{#303540}

Powered by Google App Engine
This is Rietveld 408576698