Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/BUILD.gn

Issue 702003002: Make *some* version of the Mac GN build work. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: skip //chrome/tests on mac and win Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/services/BUILD.gn ('k') | sandbox/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/BUILD.gn
diff --git a/net/BUILD.gn b/net/BUILD.gn
index 76e24a56421324053a309234bd844320bff425e2..1815ea59b76208b9433aaa725d15ed05895a828a 100644
--- a/net/BUILD.gn
+++ b/net/BUILD.gn
@@ -1065,7 +1065,8 @@ if (is_android || is_linux) {
# TODO(GYP) make this compile on Android, we need some native test deps done.
# TODO(GYP) Also doesn't work on Windows; dependency on boringssl is wrong.
-if (!is_android && !is_win) {
+# TODO(GYP) Also doesn't work on Mac, need to figure out why not.
+if (!is_android && !is_win && !is_mac) {
source_set("quic_tools") {
sources = [
@@ -1367,4 +1368,4 @@ executable("quic_server") {
]
}
-} # !is_android
+} # !is_android && !is_win && !is_mac
« no previous file with comments | « mojo/services/BUILD.gn ('k') | sandbox/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698