Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4408)

Unified Diff: chrome/renderer/searchbox/searchbox.cc

Issue 701973002: Separate checking the user identity and checking if the user is syncing his history in two differen… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Answered kmadhusu and dcheng Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/searchbox/searchbox.cc
diff --git a/chrome/renderer/searchbox/searchbox.cc b/chrome/renderer/searchbox/searchbox.cc
index f639bfc9c5933efc96709349d321850188b13b92..9adce8536714bf97658937ee385048a46db5c780 100644
--- a/chrome/renderer/searchbox/searchbox.cc
+++ b/chrome/renderer/searchbox/searchbox.cc
@@ -177,6 +177,11 @@ void SearchBox::CheckIsUserSignedInToChromeAs(const base::string16& identity) {
render_view()->GetRoutingID(), page_seq_no_, identity));
}
+void SearchBox::CheckIsUserSyncingHistory() {
+ render_view()->Send(new ChromeViewHostMsg_HistorySyncCheck(
+ render_view()->GetRoutingID(), page_seq_no_));
+}
+
void SearchBox::DeleteMostVisitedItem(
InstantRestrictedID most_visited_item_id) {
render_view()->Send(new ChromeViewHostMsg_SearchBoxDeleteMostVisitedItem(
@@ -296,6 +301,8 @@ bool SearchBox::OnMessageReceived(const IPC::Message& message) {
OnChromeIdentityCheckResult)
IPC_MESSAGE_HANDLER(ChromeViewMsg_DetermineIfPageSupportsInstant,
OnDetermineIfPageSupportsInstant)
+ IPC_MESSAGE_HANDLER(ChromeViewMsg_HistorySyncCheckResult,
+ OnHistorySyncCheckResult)
IPC_MESSAGE_HANDLER(ChromeViewMsg_SearchBoxFocusChanged, OnFocusChanged)
IPC_MESSAGE_HANDLER(ChromeViewMsg_SearchBoxMarginChange, OnMarginChange)
IPC_MESSAGE_HANDLER(ChromeViewMsg_SearchBoxMostVisitedItemsChanged,
@@ -373,6 +380,13 @@ void SearchBox::OnFocusChanged(OmniboxFocusState new_focus_state,
}
}
+void SearchBox::OnHistorySyncCheckResult(bool sync_history) {
+ if (render_view()->GetWebView() && render_view()->GetWebView()->mainFrame()) {
+ extensions_v8::SearchBoxExtension::DispatchHistorySyncCheckResult(
+ render_view()->GetWebView()->mainFrame(), sync_history);
+ }
+}
+
void SearchBox::OnMarginChange(int margin) {
start_margin_ = margin;
if (render_view()->GetWebView() && render_view()->GetWebView()->mainFrame()) {

Powered by Google App Engine
This is Rietveld 408576698