Separate checking the user identity and checking if the user is syncing his history in two differen…

chrome/browser/ui/search/search_ipc_router_policy_impl.cc

Index: chrome/browser/ui/search/search_ipc_router_policy_impl.cc
diff --git a/chrome/browser/ui/search/search_ipc_router_policy_impl.cc b/chrome/browser/ui/search/search_ipc_router_policy_impl.cc
index 11d133657dfff9ddc3cfa7fb93e2277e43db09b6..bbab087c52c5dcba32b77bf451d2a4ec86097d0d 100644
--- a/chrome/browser/ui/search/search_ipc_router_policy_impl.cc
+++ b/chrome/browser/ui/search/search_ipc_router_policy_impl.cc
@@ -59,6 +59,10 @@ bool SearchIPCRouterPolicyImpl::ShouldProcessChromeIdentityCheck() {
   return !is_incognito_ && chrome::IsInstantNTP(web_contents_);
 }
 
+bool SearchIPCRouterPolicyImpl::ShouldProcessHistorySyncCheck() {

[dcheng, 2014/11/21 20:50:32]

This shouldn't block this patch, but it's a bit strange to have so many policy
checks, most of which have the same body. Perhaps there's a better way to
express these policy checks that wouldn't require so many identical method
bodies...

[beaudoin, 2014/11/21 21:16:37]

Agreed. I'm not familiar with policy stuff though...

+  return !is_incognito_ && chrome::IsInstantNTP(web_contents_);
+}
+
 bool SearchIPCRouterPolicyImpl::ShouldSendSetPromoInformation() {
   return !is_incognito_ && chrome::IsInstantNTP(web_contents_);
 }