Separate checking the user identity and checking if the user is syncing his history in two differen…

chrome/browser/ui/search/search_ipc_router_policy_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/search/search_ipc_router_policy_impl.h"
 
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/search/search.h"
 #include "content/public/browser/web_contents.h"
 
@@ skipping 41 matching lines @@
 
 bool SearchIPCRouterPolicyImpl::ShouldProcessPasteIntoOmnibox(
     bool is_active_tab) {
   return is_active_tab && !is_incognito_ && chrome::IsInstantNTP(web_contents_);
 }
 
 bool SearchIPCRouterPolicyImpl::ShouldProcessChromeIdentityCheck() {
   return !is_incognito_ && chrome::IsInstantNTP(web_contents_);
 }
 
+bool SearchIPCRouterPolicyImpl::ShouldProcessHistorySyncCheck() {

[dcheng, 2014/11/21 20:50:32]

This shouldn't block this patch, but it's a bit strange to have so many policy
checks, most of which have the same body. Perhaps there's a better way to
express these policy checks that wouldn't require so many identical method
bodies...

[beaudoin, 2014/11/21 21:16:37]

Agreed. I'm not familiar with policy stuff though...

+  return !is_incognito_ && chrome::IsInstantNTP(web_contents_);
+}
+
 bool SearchIPCRouterPolicyImpl::ShouldSendSetPromoInformation() {
   return !is_incognito_ && chrome::IsInstantNTP(web_contents_);
 }
 
 bool SearchIPCRouterPolicyImpl::ShouldSendSetDisplayInstantResults() {
   return !is_incognito_;
 }
 
 bool SearchIPCRouterPolicyImpl::ShouldSendSetSuggestionToPrefetch() {
   return !is_incognito_;
@@ skipping 20 matching lines @@
   return !is_incognito_ && chrome::IsInstantNTP(web_contents_);
 }
 
 bool SearchIPCRouterPolicyImpl::ShouldSendToggleVoiceSearch() {
   return true;
 }
 
 bool SearchIPCRouterPolicyImpl::ShouldSubmitQuery() {
   return true;
 }