Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 701953006: PlzNavigate: Speculatively spawns a renderer process for navigations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator_impl.cc
diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc
index e3b56215d4d26daf3218f1b52f0133bda53ffdc0..efe59f69e5d677fbd1e9775e78066ee7857b0b34 100644
--- a/content/browser/frame_host/navigator_impl.cc
+++ b/content/browser/frame_host/navigator_impl.cc
@@ -738,8 +738,7 @@ void NavigatorImpl::OnBeginNavigation(
info->parent_is_main_frame = !frame_tree_node->parent() ?
false : frame_tree_node->parent()->IsMainFrame();
- // TODO(clamy): Inform the RenderFrameHostManager that a navigation is about
- // to begin, so that it can speculatively spawn a new renderer if needed.
+ frame_tree_node->render_manager()->WillBeginNavigating(params, common_params);
Charlie Reis 2014/11/05 17:50:00 nit: Let's keep with the existing naming scheme to
carlosk 2014/11/05 20:28:58 Done.
navigation_request->BeginNavigation(info.Pass(), params.request_body);
}
@@ -782,6 +781,7 @@ void NavigatorImpl::CancelNavigation(FrameTreeNode* frame_tree_node) {
CHECK(CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableBrowserSideNavigation));
navigation_request_map_.erase(frame_tree_node->frame_tree_node_id());
+ frame_tree_node->render_manager()->CleanUpCurrentNavigation();
Charlie Reis 2014/11/05 17:50:01 RFHM::CancelNavigation
carlosk 2014/11/05 20:28:58 Done. I still wanted to have a method to clean-up
}
void NavigatorImpl::LogResourceRequestTime(

Powered by Google App Engine
This is Rietveld 408576698