PlzNavigate: Speculatively spawns a renderer process for navigations.

content/browser/frame_host/navigator_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigator_impl.h"
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
 #include "base/time/time.h"
 #include "content/browser/frame_host/frame_tree.h"
@@ skipping 720 matching lines @@
   scoped_ptr<NavigationRequestInfo> info(new NavigationRequestInfo(params));
 
   info->first_party_for_cookies =
       frame_tree_node->IsMainFrame()
           ? navigation_request->common_params().url
           : frame_tree_node->frame_tree()->root()->current_url();
   info->is_main_frame = frame_tree_node->IsMainFrame();
   info->parent_is_main_frame = !frame_tree_node->parent() ?
       false : frame_tree_node->parent()->IsMainFrame();
 
-  // TODO(clamy): Inform the RenderFrameHostManager that a navigation is about
-  // to begin, so that it can speculatively spawn a new renderer if needed.
+  frame_tree_node->render_manager()->WillBeginNavigating(params, common_params);

[Charlie Reis, 2014/11/05 17:50:00]

nit: Let's keep with the existing naming scheme to have fewer names to keep
track of.  This should be RFHM::BeginNavigation.

[carlosk, 2014/11/05 20:28:58]

Done.

 
   navigation_request->BeginNavigation(info.Pass(), params.request_body);
 }
 
 // PlzNavigate
 void NavigatorImpl::CommitNavigation(FrameTreeNode* frame_tree_node,
                                      ResourceResponse* response,
                                      scoped_ptr<StreamHandle> body) {
   CHECK(CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kEnableBrowserSideNavigation));
@@ skipping 22 matching lines @@
   render_frame_host->CommitNavigation(response, body.Pass(),
                                       navigation_request->common_params(),
                                       navigation_request->commit_params());
 }
 
 // PlzNavigate
 void NavigatorImpl::CancelNavigation(FrameTreeNode* frame_tree_node) {
   CHECK(CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kEnableBrowserSideNavigation));
   navigation_request_map_.erase(frame_tree_node->frame_tree_node_id());
+  frame_tree_node->render_manager()->CleanUpCurrentNavigation();

[Charlie Reis, 2014/11/05 17:50:01]

RFHM::CancelNavigation

[carlosk, 2014/11/05 20:28:58]

Done. I still wanted to have a method to clean-up the speculative data  so I
renamed this one to CleanUpSpeculativeRenderFrameHost, made it private and
created a new one called CancelNavigation that currently just calls the former.

 }
 
 void NavigatorImpl::LogResourceRequestTime(
     base::TimeTicks timestamp, const GURL& url) {
   if (navigation_data_ && navigation_data_->url_ == url) {
     navigation_data_->url_job_start_time_ = timestamp;
     UMA_HISTOGRAM_TIMES(
         "Navigation.TimeToURLJobStart",
         navigation_data_->url_job_start_time_ - navigation_data_->start_time_);
   }
@@ skipping 121 matching lines @@
         "Navigation.TimeToCommit_ExistingRenderer_BeforeUnloadDiscounted",
         time_to_commit);
     UMA_HISTOGRAM_TIMES(
         "Navigation.TimeToURLJobStart_ExistingRenderer_BeforeUnloadDiscounted",
         time_to_network);
   }
   navigation_data_.reset();
 }
 
 }  // namespace content