Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Issue 701873002: Revert "Don't invalidate scrolling container layer when scrolling contents need invalidation" (Closed)

Created:
6 years, 1 month ago by Xianzhu
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering
Project:
blink
Visibility:
Public.

Description

Revert "Don't invalidate scrolling container layer when scrolling contents need invalidation" This reverts commit 20feb3edc199015a96b39c081d50a083cf39ac87. We still can't clearly distinguish invalidations for container layer and scrolling contents layer. For example, crbug.com/429845, the shadow div of an editor is scrollable, but the editor invalidates itself to update selection, caret and content; With the change, the invalidation will happen on the container only. Revert first and try to find a good solution. Perhaps we can just wait for slimming paint. Still keep the layout tests added in the original change but will be rebaselined. TBR=vollick@chromium.org,chrishtr@chromium.org,dsinclair@chromium.org BUG=416535, 429845 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184838

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -40 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +12 lines, -0 lines 0 comments Download
M LayoutTests/platform/linux/compositing/repaint/should-not-clip-composited-overflow-scrolling-layer-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/text-color-change-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/text-match-highlight-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
M LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/updating-scrolling-container-and-content-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M LayoutTests/platform/win/compositing/overflow/updating-scrolling-content-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/compositing/overflow/updating-scrolling-content-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/updating-scrolling-container-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayerModelObject.h View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayerModelObject.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderView.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 3 chunks +3 lines, -23 lines 0 comments Download
M Source/web/LinkHighlight.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/701873002/1
6 years, 1 month ago (2014-11-04 17:33:32 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 20:36:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184838

Powered by Google App Engine
This is Rietveld 408576698