Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1443)

Unified Diff: Source/core/rendering/RenderLayerModelObject.cpp

Issue 701873002: Revert "Don't invalidate scrolling container layer when scrolling contents need invalidation" (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderLayerModelObject.h ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderLayerModelObject.cpp
diff --git a/Source/core/rendering/RenderLayerModelObject.cpp b/Source/core/rendering/RenderLayerModelObject.cpp
index 2a6aa4a2714fc5ec26bca069a5df0e78585524e1..3e63935ffa1048de6f4fbf5a9ae84a4ab5c55414 100644
--- a/Source/core/rendering/RenderLayerModelObject.cpp
+++ b/Source/core/rendering/RenderLayerModelObject.cpp
@@ -192,7 +192,7 @@ void RenderLayerModelObject::invalidateTreeIfNeeded(const PaintInvalidationState
invalidatePaintOfSubtreesIfNeeded(childTreeWalkState);
}
-void RenderLayerModelObject::setBackingNeedsPaintInvalidationInRect(const LayoutRect& r, PaintInvalidationReason invalidationReason, const RenderObject& forRenderer) const
+void RenderLayerModelObject::setBackingNeedsPaintInvalidationInRect(const LayoutRect& r, PaintInvalidationReason invalidationReason) const
{
// https://bugs.webkit.org/show_bug.cgi?id=61159 describes an unreproducible crash here,
// so assert but check that the layer is composited.
@@ -205,8 +205,6 @@ void RenderLayerModelObject::setBackingNeedsPaintInvalidationInRect(const Layout
// Note: the subpixel accumulation of layer() does not need to be added here. It is already taken into account.
squashingLayer->setNeedsDisplayInRect(pixelSnappedIntRect(paintInvalidationRect), invalidationReason);
}
- } else if (this != forRenderer && isBox() && toRenderBox(this)->usesCompositedScrolling()) {
- layer()->compositedLayerMapping()->setScrollingContentsNeedDisplayInRect(r, invalidationReason);
} else {
layer()->compositedLayerMapping()->setContentsNeedDisplayInRect(r, invalidationReason);
}
« no previous file with comments | « Source/core/rendering/RenderLayerModelObject.h ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698