Issue 701783004: Add MinidumpMiscInfoWriter::InitializeFromSnapshot() and its test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 701783004: Add MinidumpMiscInfoWriter::InitializeFromSnapshot() and its test (Closed)

Created:
6 years, 1 month ago by Mark Mentovai

Modified:
6 years, 1 month ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@minidump_init_from_snapshot_system_info

Project:
crashpad

Visibility:
Public.

Add MinidumpMiscInfoWriter::InitializeFromSnapshot() and its test. TEST=minidump_test MinidumpMiscInfoWriter.InitializeFromSnapshot R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/bdfd147a47f4fcb44d971a743323f5f870f92805

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+510 lines, -5 lines)			Patch
M	minidump/minidump_misc_info_writer.h	View		2 chunks	+28 lines, -1 line	0 comments	Download
M	minidump/minidump_misc_info_writer.cc	View		2 chunks	+180 lines, -1 line	0 comments	Download
M	minidump/minidump_misc_info_writer_test.cc	View		4 chunks	+92 lines, -2 lines	0 comments	Download
M	minidump/minidump_system_info_writer_test.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	snapshot/snapshot.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	snapshot/test/test_process_snapshot.h	View		1 chunk	+121 lines, -0 lines	0 comments	Download
A	snapshot/test/test_process_snapshot.cc	View		1 chunk	+87 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

6 years, 1 month ago (2014-11-05 23:15:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
bdfd147a47f4fcb44d971a743323f5f870f92805 (presubmit successful).