minidump/minidump_system_info_writer_test.cc - Issue 701783004: Add MinidumpMiscInfoWriter::InitializeFromSnapshot() and its test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_system_info_writer_test.cc

Issue 701783004: Add MinidumpMiscInfoWriter::InitializeFromSnapshot() and its test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@minidump_init_from_snapshot_system_info

Patch Set: Rebase Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: minidump/minidump_system_info_writer_test.cc

diff --git a/minidump/minidump_system_info_writer_test.cc b/minidump/minidump_system_info_writer_test.cc

index a75e84b7ad5e57388539e59958ce3d4cc6ed8c99..8f96bda71bda7dd848e1788e447178ad4403ff7c 100644

--- a/minidump/minidump_system_info_writer_test.cc

+++ b/minidump/minidump_system_info_writer_test.cc

@@ -339,7 +339,6 @@ TEST(MinidumpSystemInfoWriter, InitializeFromSnapshot_X86) {

const MINIDUMP_SYSTEM_INFO* system_info;

const MINIDUMP_STRING* csd_version;

ASSERT_NO_FATAL_FAILURE(GetSystemInfoStream(file_writer.string(),

strlen(kOSVersionBuild),

&system_info,

« no previous file with comments | « minidump/minidump_misc_info_writer_test.cc ('k') | snapshot/snapshot.gyp » ('j') | no next file with comments »