Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 701683005: Service Workers/Fetch: Fix Response constructor for empty/null (Closed)

Created:
6 years, 1 month ago by jsbell
Modified:
6 years, 1 month ago
Reviewers:
horo
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, bkelly
Project:
blink
Visibility:
Public.

Description

Service Workers/Fetch: Fix Response constructor for empty/null The fetch spec[1] has the body parameter of the Response constructor marked optional, and none of the accepted types are nullable. In contrast, the Blink implementation supported passing null but required an argument. Make the impl match the spec. [1] https://fetch.spec.whatwg.org BUG=412027 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185051

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -2 lines) Patch
M LayoutTests/http/tests/serviceworker/resources/fetch-event-test-worker.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/response-content-worker.js View 1 chunk +29 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/Response.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/Response.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/Response.idl View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jsbell
horo@ - please take a look?
6 years, 1 month ago (2014-11-07 21:31:18 UTC) #2
horo
lgtm Thank you!
6 years, 1 month ago (2014-11-10 01:34:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/701683005/1
6 years, 1 month ago (2014-11-10 17:55:46 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 17:57:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185051

Powered by Google App Engine
This is Rietveld 408576698